aya-ebpf: add safety documentation for SockMap methods#1486
Open
jundorok wants to merge 1 commit into
Open
Conversation
Add `# Safety` doc sections to the three unsafe methods on `SockMap` (`update`, `redirect_msg`, `redirect_skb`) and remove the `#[expect(clippy::missing_safety_doc, reason = "TODO")]` attributes.
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
Hello @tamird |
Member
|
@jundorok I think rebasing should fix the failures. Apologies for the delay in getting back to you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
# Safetydoc sections to the three unsafe methods onSockMap(update,redirect_msg,redirect_skb)#[expect(clippy::missing_safety_doc, reason = "TODO")]attributesTest plan
cargo check -p aya-ebpfpassescargo clippy -p aya-ebpfpasses with nomissing_safety_docwarningsThis change is