[upstream #3775] feat(core): Add Apollo server cache configuration option - #53
Draft
ayim wants to merge 5 commits into
Draft
[upstream #3775] feat(core): Add Apollo server cache configuration option#53ayim wants to merge 5 commits into
ayim wants to merge 5 commits into
Conversation
Addressed PR review feedback: - Replaced custom MockCache implementation with vitest spy functionality - Removed redundant test suites (bounded cache and without cache) - Simplified test assertions to focus on successful query execution - Tests verify custom cache is configured without asserting internal Apollo cache usage patterns 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrored from vendurehq#3775 for the Overwatch review demo.
Original author: @dlhck
Description
Adds a new API configuration option
cachethat allows passing a custom cache backend to Apollo Server for server-side GraphQL response caching. This enables integration with CDNs, Redis, and other caching solutions for improved performance.The option accepts:
'bounded'- Apollo's built-in bounded cacheKeyValueCache<string>- Custom cache implementation (Redis, CDN, etc.)This feature enables better scalability and performance optimization for GraphQL APIs by allowing custom caching strategies.
Breaking changes
No
Screenshots
You can add screenshots here if applicable.
Checklist
📌 Always:
👍 Most of the time:
Summary by CodeRabbit
New Features
Tests