Open
Conversation
Owner
Author
|
Not necessary but want to eventually move to some unified/open data model. Give back to the community and all that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
/wdroute group inroutes/web.phpand importedWikidataThingControllerandWikidataTypeController, exposingGET /wd/item/{qid}andGET /wd/type/{type}with input validation and named routes.tests/Feature/WikidataRoutesTest.phpwhich binds a mockedApp\Services\Wikidatainstance and asserts entity rendering, type listing, and unsupported-type 404 handling.Mockeryto stubentityBasicsandsparqlresponses so controller + view behavior is validated without network calls.Testing
php -l routes/web.phpwhich reported no syntax errors.php -l tests/Feature/WikidataRoutesTest.phpwhich reported no syntax errors.php artisan test tests/Feature/WikidataRoutesTest.phpbut it was blocked in this environment due to a missingvendor/autoload.phpso the feature test suite could not be executed here.Codex Task