fix: copy large files to destination bucket#131
Merged
Conversation
|
Build artifact for this PR: |
There was a problem hiding this comment.
Pull request overview
This pull request fixes a cross-bucket copy bug specific to the large-file (multipart) copy path by ensuring the resolved destination bucket ID is forwarded to the SDK call, and adds a simulator-backed regression test to prevent regressions. This keeps behavior consistent between the small-file and large-file copy implementations.
Changes:
- Forward
destinationBucketIdtocopyLargeFilewhen copying across buckets. - Add a simulator-based test that forces the large-file copy path and verifies the destination bucket is honored.
- Rebuild
dist/index.jsto reflect the source changes in the published action bundle.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/commands/copy.ts | Wires destinationBucketId through to the large-file copy call for cross-bucket copies. |
| tests/commands/copy-cross-bucket.test.ts | Adds a regression test that forces multipart/large copy and asserts the destination bucket is used. |
| dist/index.js | Updates the bundled action output to include the source fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Build artifact for this PR: |
|
Build artifact for this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
distfor the action entrypoint.Linked issue
Fixes #109
Tests run
pnpm vitest run __tests__/commands/copy-cross-bucket.test.ts __tests__/coverage-stress.test.ts --testNamePattern "copy"pnpm vitest run __tests__/commands/copy-cross-bucket.test.tspnpm typecheckpnpm lintpnpm testpnpm buildpnpm verify-distvitest --coverageFollow-up notes