Skip to content

fix: copy large files to destination bucket#131

Merged
goanpeca merged 3 commits into
mainfrom
fix/109-large-copy-destination-bucket
Jun 27, 2026
Merged

fix: copy large files to destination bucket#131
goanpeca merged 3 commits into
mainfrom
fix/109-large-copy-destination-bucket

Conversation

@goanpeca

@goanpeca goanpeca commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Forward the resolved destination bucket id through shared copy options used by both small-file and large-file copy paths.
  • Keep large-file-only signal handling explicit while preventing future drift in the common copy contract.
  • Add simulator-backed large cross-bucket regression coverage that verifies copied size and bucket state without pinning a concrete SDK method call.
  • Rebuild dist for the action entrypoint.

Linked issue

Fixes #109

Tests run

  • pnpm vitest run __tests__/commands/copy-cross-bucket.test.ts __tests__/coverage-stress.test.ts --testNamePattern "copy"
  • pnpm vitest run __tests__/commands/copy-cross-bucket.test.ts
  • pnpm typecheck
  • pnpm lint
  • pnpm test
  • pnpm build
  • pnpm verify-dist
  • pre-commit hook: lint, release provenance policy, typecheck, vitest, ncc build, cspell
  • pre-push hook: vitest --coverage

Follow-up notes

  • No new user-facing input was added; this keeps the large-file copy path consistent with the existing small-file copy behavior.

Copilot AI review requested due to automatic review settings June 26, 2026 12:58
@goanpeca goanpeca added this to the v1.2.0 milestone Jun 26, 2026
@goanpeca goanpeca added bug Something isn't working enhancement New feature or request reliability Runtime resilience and failure handling sdk-parity SDK capability not yet exposed by the action labels Jun 26, 2026
@goanpeca goanpeca self-assigned this Jun 26, 2026
@github-actions

Copy link
Copy Markdown

Build artifact for this PR: build.tar.gz (valid 1 hour)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a cross-bucket copy bug specific to the large-file (multipart) copy path by ensuring the resolved destination bucket ID is forwarded to the SDK call, and adds a simulator-backed regression test to prevent regressions. This keeps behavior consistent between the small-file and large-file copy implementations.

Changes:

  • Forward destinationBucketId to copyLargeFile when copying across buckets.
  • Add a simulator-based test that forces the large-file copy path and verifies the destination bucket is honored.
  • Rebuild dist/index.js to reflect the source changes in the published action bundle.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
src/commands/copy.ts Wires destinationBucketId through to the large-file copy call for cross-bucket copies.
tests/commands/copy-cross-bucket.test.ts Adds a regression test that forces multipart/large copy and asserts the destination bucket is used.
dist/index.js Updates the bundled action output to include the source fix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown

Build artifact for this PR: build.tar.gz (valid 1 hour)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 4 changed files in this pull request and generated no new comments.

@github-actions

Copy link
Copy Markdown

Build artifact for this PR: build.tar.gz (valid 1 hour)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 4 changed files in this pull request and generated no new comments.

@goanpeca goanpeca marked this pull request as ready for review June 26, 2026 13:17
@goanpeca goanpeca merged commit 0297d69 into main Jun 27, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request reliability Runtime resilience and failure handling sdk-parity SDK capability not yet exposed by the action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

copy: scope large-file cross-bucket copy to destination bucket id

2 participants