Skip to content

fix: render extraVolumes without extraVolumeMounts #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
immanuwell wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −3
Open

fix: render extraVolumes without extraVolumeMounts #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/backstage/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ sources:
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.8.0
version: 2.8.1
2 changes: 1 addition & 1 deletion charts/backstage/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Backstage Helm Chart

[![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/backstage)](https://artifacthub.io/packages/search?repo=backstage)
![Version: 2.8.0](https://img.shields.io/badge/Version-2.8.0-informational?style=flat-square)
![Version: 2.8.1](https://img.shields.io/badge/Version-2.8.1-informational?style=flat-square)
![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)

A Helm chart for deploying a Backstage application
Expand Down
11 changes: 11 additions & 0 deletions charts/backstage/ci/extraVolumes-sidecar-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
backstage:
extraVolumes:
- name: shared-cache
emptyDir: {}
extraContainers:
- name: sidecar
image: busybox:1.36
command: ["sh", "-c", "sleep 3600"]
volumeMounts:
- name: shared-cache
mountPath: /cache
2 changes: 1 addition & 1 deletion charts/backstage/templates/backstage-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ spec:
{{- include "common.tplvalues.render" ( dict "value" .Values.backstage.hostAliases "context" $) | nindent 8 }}
{{- end }}
volumes:
{{- if (or .Values.backstage.extraAppConfig (and .Values.backstage.extraVolumeMounts .Values.backstage.extraVolumes)) }}
{{- if (or .Values.backstage.extraAppConfig .Values.backstage.appConfig .Values.backstage.extraVolumes) }}

@tumido tumido Jun 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @immanuwell , thanks for the PR! 🙂

Can you please tell me why this should now depend on .Values.backstage.appConfig ? I think that's a mistake.

It already has a separate mount point below:

charts/charts/backstage/templates/backstage-deployment.yaml

Lines 82 to 86 in a33ab0e

{{- if .Values.backstage.appConfig }}
- name: backstage-app-config
configMap:
name: {{ include "common.names.fullname" . }}-app-config
{{- end }}

{{- range .Values.backstage.extraAppConfig }}
- name: {{ .configMapRef }}
configMap:
Expand Down
Loading