Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependency @date-io/luxon to v3 #8764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Update dependency @date-io/luxon to v3 #8764
Changes from all commits
60ac999File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@material-ui/pickers@3.3.xin this workspace depends on@date-io/core1.x and peers@date-io/core^1.3.6(see this workspace’syarn.lock).@date-io/luxon@3.xdepends on@date-io/core3.x, which introduces breaking API/type changes and is likely incompatible with@material-ui/pickers. Suggest keeping@date-io/luxonon 1.x (as previously noted in this plugin’s changelog rollback) until the picker stack is upgraded.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@material-ui/pickersv3 depends on@date-io/core1.x and date-io release notes warn against upgrading date-io when using pickers v3. Updating@date-io/luxonto 3.x is therefore likely incompatible (type/runtime break). Recommend keeping@date-io/luxonon 1.x until pickers is migrated to a compatible stack.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependency range for
@date-io/luxonis inconsistent across workspaces (^3.0.0here vs3.xelsewhere). Standardizing the version range across packages will make upgrades and lockfile behavior more predictable (e.g., choose either^3.2.0/^3.0.0everywhere or3.xeverywhere).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This plugin still uses
@material-ui/pickers@3.x, which depends on@date-io/core: 1.xand peers@date-io/core: ^1.3.6(see this workspace yarn.lock).@date-io/luxon@3.xbrings in@date-io/core@^3.2.0and date-io v2/v3 breaking changes, so this is likely an incompatible combination. Please either keep@date-io/luxonpinned to1.xwhile using pickers v3, or migrate to a picker library that supports date-io v3.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workspace still depends on
@material-ui/pickers@^3.3.10, which expects@date-io/core@^1.x, but@date-io/luxon@^3.0.0brings in@date-io/core@^3. That version gap can cause incompatibilities in the pickers utils provider. Consider reverting@date-io/luxonto^1.3.13until the picker stack is migrated, or upgrade the picker implementation to one compatible with date-io v3.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@material-ui/pickers@3.3.xdepends on@date-io/core1.x and peers@date-io/core^1.3.6(see this workspace’syarn.lock). Upgrading@date-io/luxonto 3.x pulls in@date-io/core3.x with breaking API/type changes and is likely incompatible with@material-ui/pickers’ expected utils interface. Please keep@date-io/luxonon 1.x until the picker stack is upgraded/migrated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@material-ui/pickers@3.3.xin this workspace depends on@date-io/core1.x and peers@date-io/core^1.3.6(see this workspace’syarn.lock). Upgrading@date-io/luxonto 3.x pulls in@date-io/core3.x with breaking API/type changes and is likely to break the pickers integration (this plugin previously rolled back a similar bump per its changelog). Please keep@date-io/luxonon 1.x until the picker stack is upgraded.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@material-ui/pickersv3 depends on@date-io/core1.x and date-io release notes warn against upgrading date-io when using pickers v3. Updating@date-io/luxonto 3.x is therefore likely incompatible (type/runtime break). Recommend keeping@date-io/luxonon 1.x until pickers is migrated to a compatible stack.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@material-ui/pickers@3.3.10is historically coupled to@date-io/*@1.x, and@date-iov2+ explicitly warns about compatibility with MUI pickers v3. Upgrading@date-io/luxonto3.xrisks runtime/type incompatibilities in date picker integration. Recommended: either keep@date-io/luxonpinned to1.xfor packages still using@material-ui/pickers@3, or migrate off@material-ui/pickersto a picker library compatible with@date-iov3 (and update adapters/usage accordingly).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@date-io/luxonv3 release notes indicate TypeScript 5 is required due to removed/updated type definitions. If this repo (or the specific workspaces) compile with TypeScript < 5, this upgrade can break builds. Please confirm the TypeScript version used in CI/build tooling meets this requirement (or bump it as part of this PR if needed).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With
@date-io/luxon@3.x,luxonis an optional peer dependency. This package uses Luxon-based pickers (MuiPickersUtilsProvider utils={LuxonUtils}) but does not declareluxonas a dependency, which can lead to non-deterministic installs (works only if some other dependency happens to pullluxon). Add an explicitluxondependency (matching the desired major) to ensure the adapter can resolve it reliably.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@date-io/luxon@3.xdeclaresluxonas an optional peer dependency in the lockfile. This package is used at runtime (viaMuiPickersUtilsProvider utils={LuxonUtils}), so the plugin should listluxonas a direct dependency to ensure consumers don’t end up with a missing/hoisted peer at runtime.Uh oh!
There was an error while loading. Please reload this page.