Skip to content

chore(deps): bump path-to-regexp from 6.3.0 to 8.4.2#11371

Draft
jNullj wants to merge 3 commits intobadges:masterfrom
jNullj:chore/npm/path-to-regexp-v6-to-v8
Draft

chore(deps): bump path-to-regexp from 6.3.0 to 8.4.2#11371
jNullj wants to merge 3 commits intobadges:masterfrom
jNullj:chore/npm/path-to-regexp-v6-to-v8

Conversation

@jNullj
Copy link
Copy Markdown
Member

@jNullj jNullj commented Sep 23, 2025

Some work that needs to be done pointed at this comment
Links to a list of breaking changes for: v7, v8

@jNullj jNullj added the dependencies Related to dependency updates label Sep 23, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 23, 2025

Messages
📖 ✨ Thanks for your contribution to Shields, @jNullj!

Generated by 🚫 dangerJS against 07c85ae

@jNullj
Copy link
Copy Markdown
Member Author

jNullj commented Sep 24, 2025

A few new insights

  1. There is simply too much regex, every pattern's enum is not supports.
  2. Rewriting all routes is lots of work.
  3. I looked at a potential replacement regexparam, seems to not be easy to work with as it also does not support regex operations we need.
  4. Another alternative url-pattern is unmaintained for 9 years.
  5. I looked into how this will effect our move to express as we might be able to use some of it's functionality, and surprised to learn that express uses path-to-regexp.

some alternatives to pattern enum might be:

  1. Accepting any string as route and validating the enum in service.
  2. Extracting pattern options at prepareRoute and recreate the regex with the options (also should effect getEnum function).

@jNullj jNullj force-pushed the chore/npm/path-to-regexp-v6-to-v8 branch from fa90feb to 07c85ae Compare April 11, 2026 16:30
@jNullj jNullj changed the title chore(deps): bump path-to-regexp from 6.3.0 to 8.3.0 chore(deps): bump path-to-regexp from 6.3.0 to 8.4.2 Apr 11, 2026
@jNullj
Copy link
Copy Markdown
Member Author

jNullj commented Apr 11, 2026

to solve this issue i think we better present a new boilerplate for enums.
considering we want to move to express.js in the future and that enums in paths are removed by design i think we should use per-badge enum check.
we have over 20 services to change, i think its best to brake it down to seperate PR to slowly change the code-base so we can ublock this PR.

i will start out by updating docs so future badges will be added correctly and we have a clear plane.
then i will hit multiple PR to include services in small chunks so we actually make progress towards this and not just stay with a huge roadblock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related to dependency updates

Development

Successfully merging this pull request may close these issues.

1 participant