Open
Conversation
Contributor
auth test used example provided for filter. auth test and provided example did not match changed example to match test.
Contributor
|
🚀 Updated review app: https://pr-11745-badges-shields.fly.dev |
Contributor
|
Hi, |
Member
Author
Yes, we are using the matcher package here, which supports negative patterns like You are free to test using the preview site mentioned in this PR for a live version of shields based on these change |
Contributor
|
I can't reach https://pr-11745-badges-shields.fly.dev/ 
|
Contributor
|
🚀 Updated review app: https://pr-11745-badges-shields.fly.dev |
Member
|
@reda-alaoui I've restarted the review app :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add version filter to Nexus as requested in #11742
Was not sure about sorting, i used
mvncmpbut im not sure if most nexus users expects maven like sort.Please provide feedback regarding the change.