fix(nuget): fix double URL encoding for non-ASCII package names; test [Nuget MyGet]#11795
Merged
PyvesB merged 3 commits intobadges:masterfrom Apr 12, 2026
Merged
Conversation
packageName was passed through encodeURIComponent() before being added to searchParams. Since got also encodes searchParams values, characters like ò (%C3%B2) were double-encoded (%25C3%25B2), causing NuGet's search API to receive the literal percent-encoded string and return 0 hits. Fixes badges#7942
Contributor
|
PyvesB
changed the title
PyvesB
reviewed
Apr 11, 2026
PyvesB
changed the title
PyvesB
reviewed
Apr 11, 2026
Co-authored-by: Pierre-Yves Bigourdan <10694593+PyvesB@users.noreply.github.com>
Co-authored-by: Pierre-Yves Bigourdan <10694593+PyvesB@users.noreply.github.com>
PyvesB
approved these changes
Apr 12, 2026
Member
PyvesB
left a comment
PyvesB
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Love these PRs where code is removed (tests aside) to fix bugs 😄
Contributor
Author
|
happy to help. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packageName was passed through encodeURIComponent() before being added to searchParams. Since got also encodes searchParams values, characters like ò (%C3%B2) were double-encoded (%25C3%25B2), causing NuGet's search API to receive the literal percent-encoded string and return 0 hits.
Fixes #7942