Create crda.yml#15
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Check out repository | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
Checkout pulls base branch instead of PR head
The workflow uses the pull_request_target event but the checkout step relies on the default ref, which in this event type resolves to the repository’s default branch rather than the pull request’s head. That means the CRDA scan always analyzes the base branch and ignores any dependency changes introduced by the PR, defeating the purpose of scanning incoming contributions. Override actions/checkout with ref: ${{ github.event.pull_request.head.sha }} (and repository for forks) or trigger on pull_request to ensure PR code is actually scanned.
Useful? React with 👍 / 👎.
No description provided.