Skip to content

Create crda.yml#15

Open
bakaxbaka wants to merge 1 commit into
mainfrom
bakaxbaka-patch-2
Open

Create crda.yml#15
bakaxbaka wants to merge 1 commit into
mainfrom
bakaxbaka-patch-2

Conversation

@bakaxbaka

Copy link
Copy Markdown
Owner

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +83 to +84
- name: Check out repository
uses: actions/checkout@v4

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Checkout pulls base branch instead of PR head

The workflow uses the pull_request_target event but the checkout step relies on the default ref, which in this event type resolves to the repository’s default branch rather than the pull request’s head. That means the CRDA scan always analyzes the base branch and ignores any dependency changes introduced by the PR, defeating the purpose of scanning incoming contributions. Override actions/checkout with ref: ${{ github.event.pull_request.head.sha }} (and repository for forks) or trigger on pull_request to ensure PR code is actually scanned.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant