fix webresource write#54
Open
otaviojacobi wants to merge 1 commit into
Open
Conversation
otaviojacobi
force-pushed
the
otavio-fix-webresource-write
branch
from
March 12, 2024 13:23
8d27ef8 to
c04b83a
Compare
Page-
reviewed
Mar 12, 2024
otaviojacobi
marked this pull request as ready for review
March 12, 2024 13:28
Change-type: patch
otaviojacobi
force-pushed
the
otavio-fix-webresource-write
branch
from
March 12, 2024 13:42
c04b83a to
e5c6f1d
Compare
Page-
reviewed
Mar 12, 2024
| `, | ||
| write: '', | ||
| write: ` | ||
| export interface WebResourceWrite extends Blob { |
Contributor
There was a problem hiding this comment.
I don't think this type is actually correct because you can send other things to the server right? eg based on https://github.com/balena-io-modules/sbvr-types/blob/v7.0.1/src/types/web-resource.ts#L94-L102 then either string or object is valid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.