Update node resolver#47
Conversation
|
@klutchell , @dfunckt This fix is simple. I rarely work in this area, so want to confirm I'm not missing any context that would affect the change. I'm scratching my head because the resin repository was deprecated 5 years ago. It seems like we would have noticed this error sooner. |
We are optionally skipping that test, which is why we didn't notice it sooner. I expect that's actually WHY we are skipping that test. |
|
I suggest we remove the balena-compose/test/resolve/all.spec.ts Line 312 in 0d71e1c |
|
This is the offending commit: balena-io-modules/resin-bundle-resolve@938f5e3 |
|
Thanks, I'll activate the test, confirm it has the expected result, and then self-approve. |
|
I would be happy to review and approve once the test is re-enabled. No need to self-certify today :) |
Change-type: patch Signed-off-by: Ken Bannister <kb2ma@runbox.com>
Change-type: patch Signed-off-by: Ken Bannister <kb2ma@runbox.com>
Also expect that the (final) result from retrieving node image tags may be undefined. Change-type: patch Signed-off-by: Ken Bannister <kb2ma@runbox.com>
Also update expected node version for use with balenalib repo on Docker Hub. Signed-off-by: Ken Bannister <kb2ma@runbox.com>
1617f4d to
2072920
Compare
|
Reactivated the node project test. I had to update the node version to one available in the balenalib repository. Also I found that the result from querying Docker Hub might be undefined. The possibility of that error may have been the reason for skipping the test. The test pretty consistently takes 40 sec., which also might be why the test was skipped. |
I suspect the test was skipped due to the undefined result. Does this fail the test? Do you think this is also affecting users in production (if anyone even deploys without Dockerfiles anymore)? |
4 participants
Node resolver was using obsolete 'resin' repository; update to use 'balenalib'.
Also included a whitespace fix for prettier so can run tests.