Adds support for device/kernel configurations and tmpfs#141
Merged
Conversation
pipex
marked this pull request as draft
July 17, 2026 21:16
pipex
force-pushed
the
compose-devices
branch
2 times, most recently
from
July 20, 2026 21:04
ac78943 to
8cf4f8b
Compare
Maps the user configured services.devices compose property to the devices configuration on the container. CDI syntax is not supported for now Change-type: patch
The field is read directly from the composition and passed to the container. No validation is performed in accordance with the spec Change-type: patch
Change-type: patch
Change-type: patch
cywang117
reviewed
Jul 23, 2026
| .collect(); | ||
| // Sort by target so the serialized form is stable regardless of the | ||
| // order the engine reports the devices in (see the volumes sort below). | ||
| devices.sort_by(|a, b| a.target.cmp(&b.target)); |
Contributor
There was a problem hiding this comment.
Why not do the same for device_cgroup_rules?
Contributor
Author
There was a problem hiding this comment.
Mostly because is more code and is not a common configuration and I'd expect it to be rare than users change the order in the composition. The same is probably true for devices, I just added the sort to match what we do with volumes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for compose properties
devices,device_cgroup_rules,ulimitsandtmpfs