Skip to content

Improve documentation, enhance downloader, and update configurations#167

Closed
peter9811 wants to merge 13 commits into
bambanah:mainfrom
peter9811:main
Closed

Improve documentation, enhance downloader, and update configurations#167
peter9811 wants to merge 13 commits into
bambanah:mainfrom
peter9811:main

Conversation

@peter9811

Copy link
Copy Markdown

Update the README for clarity, enhance playlist generation in the downloader with relative paths, improve error handling in the build process, and update ESLint and TypeScript configurations for better compatibility. Additionally, add GUI vitest configuration to the workspace.

feat(downloader): enhance playlist generation with relative paths

fix(build): improve error handling and resource copying in production mode

chore(eslint): update ESLint configuration for better compatibility

chore(tsconfig): include script directories in TypeScript configuration

chore(vitest): add gui vitest configuration to workspace
@peter9811 peter9811 requested a review from bambanah as a code owner February 28, 2025 03:24
@changeset-bot

changeset-bot Bot commented Feb 28, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2daf3a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
deemix-cli Major
deemix Major
deezer-sdk Major
deemix-gui Major
deemix-webui Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…/types.ts`

* Add `downloadURL` property with type `string` to `APITrack` interface
* Remove redundant comments and adjust formatting for consistency
This commit introduces a comprehensive refactoring of the ESLint configuration with several key improvements:

- Migrate to flat config format for ESLint
- Update TypeScript and Vue plugin configurations
- Add more strict and opinionated linting rules
- Improve type checking and code quality rules
- Update package dependencies to support new configuration
- Enhance project-wide linting and type safety
@bambanah

bambanah commented Mar 3, 2025

Copy link
Copy Markdown
Owner

Really appreciate the effort put into this one, but could you please keep each PR to a single responsibility? It's incredibly hard to review a PR that touches almost every part of the codebase at once 😂

@Gauvino

Gauvino commented Apr 15, 2025

Copy link
Copy Markdown

@peter9811 could look again on this ?

peter9811 and others added 8 commits April 17, 2025 19:11
…dates

Bumps the npm_and_yarn group with 3 updates in the / directory: [esbuild](https://github.com/evanw/esbuild), [vue-i18n](https://github.com/intlify/vue-i18n/tree/HEAD/packages/vue-i18n) and [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite).


Updates `esbuild` from 0.24.0 to 0.25.0
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG-2024.md)
- [Commits](evanw/esbuild@v0.24.0...v0.25.0)

Updates `vue-i18n` from 10.0.4 to 10.0.6
- [Release notes](https://github.com/intlify/vue-i18n/releases)
- [Changelog](https://github.com/intlify/vue-i18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/intlify/vue-i18n/commits/v10.0.6/packages/vue-i18n)

Updates `vite` from 5.4.10 to 5.4.18
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.4.18/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.4.18/packages/vite)

Updates `@intlify/core-base` from 10.0.4 to 10.0.6
- [Release notes](https://github.com/intlify/vue-i18n/releases)
- [Changelog](https://github.com/intlify/vue-i18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/intlify/vue-i18n/commits/v10.0.6/packages/core)

Updates `@intlify/shared` from 10.0.4 to 10.0.6
- [Release notes](https://github.com/intlify/vue-i18n/releases)
- [Changelog](https://github.com/intlify/vue-i18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/intlify/vue-i18n/commits/v10.0.6/packages/shared)

Updates `rollup` from 4.21.2 to 4.24.3
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v4.21.2...v4.24.3)

---
updated-dependencies:
- dependency-name: esbuild
  dependency-version: 0.25.0
  dependency-type: direct:development
  dependency-group: npm_and_yarn
- dependency-name: vue-i18n
  dependency-version: 10.0.6
  dependency-type: direct:production
  dependency-group: npm_and_yarn
- dependency-name: vite
  dependency-version: 5.4.18
  dependency-type: direct:development
  dependency-group: npm_and_yarn
- dependency-name: "@intlify/core-base"
  dependency-version: 10.0.6
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: "@intlify/shared"
  dependency-version: 10.0.6
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: rollup
  dependency-version: 4.24.3
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
…yarn-0d2834bdc3

build(deps): bump the npm_and_yarn group across 1 directory with 6 updates
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Bumps the npm_and_yarn group with 1 update in the / directory: [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite).


Updates `vite` from 5.4.18 to 6.0.15
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v6.0.15/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v6.0.15/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 6.0.15
  dependency-type: direct:development
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
…yarn-37b9442ea0

build(deps-dev): bump vite from 5.4.18 to 6.0.15 in the npm_and_yarn group across 1 directory
…2 updates

Bumps the npm_and_yarn group with 2 updates in the / directory: [esbuild](https://github.com/evanw/esbuild) and [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite).


Updates `esbuild` from 0.25.2 to 0.25.3
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md)
- [Commits](evanw/esbuild@v0.25.2...v0.25.3)

Updates `vite` from 6.2.2 to 6.2.6
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v6.2.6/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v6.2.6/packages/vite)

---
updated-dependencies:
- dependency-name: esbuild
  dependency-version: 0.25.3
  dependency-type: direct:development
  dependency-group: npm_and_yarn
- dependency-name: vite
  dependency-version: 6.2.6
  dependency-type: direct:development
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
@peter9811 peter9811 closed this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants