Skip to content

Fix and improve ownership init script#235

Merged
bambanah merged 3 commits into
bambanah:mainfrom
ametis70:improve-fix-folders-init-script
Dec 15, 2025
Merged

Fix and improve ownership init script#235
bambanah merged 3 commits into
bambanah:mainfrom
ametis70:improve-fix-folders-init-script

Conversation

@ametis70

@ametis70 ametis70 commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Summary

  • Added two env vars for disabling chown on container init for data and music directories: DISABLE_OWNERSHIP_CHECK_MUSIC and DISABLE_OWNERSHIP_CHECK_DATA
  • Using DISABLE_OWNERSHIP_CHECK now disables chown for both directories as expected

Checklist

  • I have tested the changes locally and they work as expected
  • This PR contains a changeset (pnpm changeset)

@ametis70 ametis70 requested a review from bambanah as a code owner September 2, 2025 04:49
@changeset-bot

changeset-bot Bot commented Sep 2, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 406a8c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
deemix-webui Minor
deemix-gui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ametis70 ametis70 marked this pull request as draft September 2, 2025 04:50
@ametis70 ametis70 force-pushed the improve-fix-folders-init-script branch from 0c8bcfc to 98dea03 Compare September 3, 2025 22:03
@ametis70 ametis70 marked this pull request as ready for review September 3, 2025 22:04
@ametis70

ametis70 commented Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

@bambanah Could you review this? To generate a new Docker image, should we bump the version? I didn't add the changeset because I don't know if that flow is only for code changes. If it is required, I can add it

@bambanah bambanah left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry mate, didn't get pinged for this. Yep we'll need to add a changeset for the webui package for these scripts to be included in the build.

@ametis70

Copy link
Copy Markdown
Contributor Author

I didn't see your response either, sorry! I just pushed the changeset, is it okay like that?

@bambanah bambanah force-pushed the improve-fix-folders-init-script branch from a2e5e05 to 406a8c4 Compare December 14, 2025 22:58

@bambanah bambanah left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! That's perfect

@bambanah bambanah merged commit a0b3fc8 into bambanah:main Dec 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants