feat(webui): remove dead email/password login (ARL only) + harden ARL login#311
Merged
Merged
Conversation
Strip surrounding whitespace/newlines from the submitted ARL and reject values containing non-hex characters (e.g. a full cookie row pasted from DevTools) with an explicit "invalidArl" error. Previously a malformed ARL failed deep in the cookie jar with an opaque "Cookie failed to parse" and surfaced to the user only as a generic "Couldn't log in". Also fixes a missing early return so the 400 (missing arl) path no longer falls through to the login flow.
🦋 Changeset detectedLatest commit: 7ef9e63 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deezer blocks the legacy auth/token email/password endpoint (HTTP 403), so that login path could never succeed and only ever surfaced as a generic "Couldn't log in". Remove the email/password form, the loginEmail route, and the access-token plumbing (login store, loginStorage, types); ARL login is now shown directly in Settings as the only method.
richardtru
changed the title
bambanah
approved these changes
Jun 18, 2026
bambanah
left a comment
bambanah
left a comment
Owner
There was a problem hiding this comment.
Perfect PR, thanks for the contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deezer blocks the legacy
auth/tokenemail/password endpoint — it returnsHTTP 403 (Access Denied)for everyone, not just bad credentials:So the email/password login path could never succeed; it only ever surfaced as a generic "Couldn't log in" (the 403 HTML breaks
response.json(), which is swallowed by an emptycatch). This PR removes that dead path and makes ARL the only login method, and hardens ARL login along the way.Removed (dead email/password login)
loginEmailroute + its registration.accessTokenin the login store,loginStorage,LoginFile, thegetAccessToken/getArlFromAccessTokenre-exports indeemixApp, and theloginWithCredentialsautologin fallback inclient/main.ts.Note: the underlying
deemixlibrary utils (getDeezerAccessTokenFromEmailPassword/getDeezerArlFromAccessToken) are intentionally left in place to avoid a breaking change to the published library API — only the app-level usage is removed.Hardened (ARL login)
{ status: 0, error: "invalidArl" }and a specific toast — "Invalid ARL. Copy only the cookie value — no spaces, quotes or extra text." — instead of failing deep in the cookie jar with an opaqueCookie failed to parse.returnso the400(missingarl) guard no longer falls through into the login flow.Screenshots (if applicable)
N/A — Settings login section now shows the ARL field directly; no email/password form.
Checklist
pnpm changeset)Verified locally:
pnpm run ci(lint + type-check + build + test, all packages) passes 19/19.