Added params to the button lookbook preview#485
Open
felp99 wants to merge 1 commit intobaoagency:mainfrom
Open
Added params to the button lookbook preview#485felp99 wants to merge 1 commit intobaoagency:mainfrom
felp99 wants to merge 1 commit intobaoagency:mainfrom
Conversation
Collaborator
|
Hey! Thanks for the PR. To be honest, not sure how useful it is to have playground previews in Lookbook. The only value I see is to quickly try some settings. But you can't copy the final code with filled-in parameters. 
In that sense regular preview methods are much more useful. You can see it visually and copy example code right away. 
|
Author
|
My main idea was to show the developer the possibilities, since as it stands now we cannot clearly see everything that can be done in terms of parameters. How would you do it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #180
Add interactive playground to ButtonComponent preview
Adds a
playgroundpreview method toButtonComponentPreviewthat allows developers to interactively explore allButtonComponentoptions from the Lookbook UI.Changes
playgroundmethod toButtonComponentPreviewwith@paramannotations for all supported button options (label, URL, icon, tooltip, size, alignment, disclosure, and all boolean toggles)playground.html.erbtemplate that renders a fully configuredpolaris_buttonusing all the exposed parametersWhy
The existing previews each demonstrate a single feature in isolation. The playground gives developers a single interactive surface to combine any set of options and see the result live, which is useful for testing and exploration during development.