Skip to content

🔧 Add typecheck CI workflow for pull requests#2433

Merged
baptisteArno merged 4 commits intomainfrom
baptisteArno/ci-typecheck-pr
Apr 7, 2026
Merged

🔧 Add typecheck CI workflow for pull requests#2433
baptisteArno merged 4 commits intomainfrom
baptisteArno/ci-typecheck-pr

Conversation

@baptisteArno
Copy link
Copy Markdown
Owner

Summary

  • Adds a new GitHub Actions workflow that runs bunx nx affected -t typecheck on every pull request
  • Uses the PR base branch as the Nx affected comparison base for accurate change detection
  • Sets up Node 24 + Bun with full git history for proper affected analysis

Test plan

  • Open a PR with a type error and verify the check fails
  • Open a PR with no type errors and verify the check passes

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions[bot]
github-actions bot previously approved these changes Apr 7, 2026
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
builder-v2 Ignored Ignored Preview Apr 7, 2026 3:06pm
landing-page-v2 Ignored Ignored Preview Apr 7, 2026 3:06pm
viewer-v2 Ignored Ignored Apr 7, 2026 3:06pm

Request Review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0d6adc43b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

The landing-page app depends on generated types from @content-collections/cli
that must exist before tsc --build can succeed.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions[bot]
github-actions bot previously approved these changes Apr 7, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions[bot]
github-actions bot previously approved these changes Apr 7, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@baptisteArno baptisteArno merged commit c9422f6 into main Apr 7, 2026
10 checks passed
@baptisteArno baptisteArno deleted the baptisteArno/ci-typecheck-pr branch April 7, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant