🐛 Fix stored XSS via javascript: URI in bubble links (GHSA-hqmv-v56g-4m47)#2435
Merged
baptisteArno merged 6 commits intomainfrom Apr 7, 2026
Merged
🐛 Fix stored XSS via javascript: URI in bubble links (GHSA-hqmv-v56g-4m47)#2435baptisteArno merged 6 commits intomainfrom
baptisteArno merged 6 commits intomainfrom
Conversation
…4m47) Sanitize href attributes in PlateBlock, ImageBubble, and Bot toast links by filtering out dangerous URI schemes (javascript:, data:, vbscript:). Only http:, https:, mailto:, and tel: protocols are allowed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Next.js projects don't get a typecheck target inferred by the @nx/js/typescript plugin. Add explicit tsc --noEmit targets so `bunx nx typecheck builder` and `bunx nx typecheck viewer` work. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3284e67864
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Workflow polls for a Codex review on every PR. It also re-triggers on pull_request_review events from the Codex bot to cancel the polling run and succeed immediately. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The react embed package exports types from its dist/ folder, so it must be built before other projects can typecheck against it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
javascript:URIs in text bubble links, image click links, and toast popup links could execute arbitrary JS in visitors' browserssanitizeUrlutility that allowlists onlyhttp:,https:,mailto:, andtel:protocolstypecheckNx targets forbuilderandviewer(Next.js projects don't get one inferred by@nx/js/typescript)@typebot.io/jsand@typebot.io/reactto0.10.1Test plan
javascript:alert(1)and verify it renders as#https://links still workbunx nx typecheck builderandbunx nx typecheck viewer🤖 Generated with Claude Code