ci: drop approve step from Dependabot auto-merge workflow#156
Merged
Conversation
The approve step requires "Allow GitHub Actions to create and approve pull requests" at the repo level, which is off here, so the workflow fails on approve and the auto-merge step never runs. Without branch protection requiring reviews, the approve was cosmetic anyway — the auto-merge step alone gates on CI, which is the actual safety check.
Sensitive Change Detection (shadow mode)This PR modifies control-plane files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Dependabot auto-merge GitHub Actions workflow to remove the gh pr review --approve step, avoiding failures when the repository setting “Allow GitHub Actions to create and approve pull requests” is disabled, while keeping auto-merge behavior unchanged.
Changes:
- Removed the workflow step that attempted to approve eligible Dependabot PRs via
gh pr review --approve. - Kept the existing “enable auto-merge for patch/minor (excluding GitHub Actions)” logic intact.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Summary by cubic
Removed the
gh pr review --approvestep from.github/workflows/dependabot-auto-merge.ymlto stop failures when action approvals are disallowed and restore Dependabot auto-merge. Thegh pr merge --auto --squashstep is unchanged and still waits for required CI.Written for commit 35bb4a7. Summary will update on new commits. Review in cubic