Skip to content

ci: drop approve step from Dependabot auto-merge workflow#156

Merged
jeremy merged 1 commit into
masterfrom
ci/dependabot-auto-merge-drop-approve
Apr 29, 2026
Merged

ci: drop approve step from Dependabot auto-merge workflow#156
jeremy merged 1 commit into
masterfrom
ci/dependabot-auto-merge-drop-approve

Conversation

@jeremy

@jeremy jeremy commented Apr 29, 2026

Copy link
Copy Markdown
Member

Summary

  • Remove the `gh pr review --approve` step from `.github/workflows/dependabot-auto-merge.yml`. It fails because the repo-level setting Allow GitHub Actions to create and approve pull requests is off, which blocks the workflow before the auto-merge step ever runs (e.g. deps: bump github.com/basecamp/fizzy-sdk/go from 0.1.2 to 0.1.3 in the go-dependencies group across 1 directory #150).
  • `master` has no branch protection requiring reviews, so the approve was cosmetic. The `gh pr merge --auto --squash` step is unchanged and still gates on CI — the actual safety check.
  • Trade-off vs flipping the repo setting (which is what basecamp-cli/hey-cli do): we diverge from the sibling repos and lose the green "Approved" badge on merged Dependabot PRs, but the workflow becomes self-contained and doesn't depend on a setting that can be silently toggled off.

Test plan


Summary by cubic

Removed the gh pr review --approve step from .github/workflows/dependabot-auto-merge.yml to stop failures when action approvals are disallowed and restore Dependabot auto-merge. The gh pr merge --auto --squash step is unchanged and still waits for required CI.

Written for commit 35bb4a7. Summary will update on new commits. Review in cubic

The approve step requires "Allow GitHub Actions to create and approve
pull requests" at the repo level, which is off here, so the workflow
fails on approve and the auto-merge step never runs. Without branch
protection requiring reviews, the approve was cosmetic anyway — the
auto-merge step alone gates on CI, which is the actual safety check.
Copilot AI review requested due to automatic review settings April 29, 2026 20:10
@github-actions

Copy link
Copy Markdown

Sensitive Change Detection (shadow mode)

This PR modifies control-plane files:

  • .github/workflows/dependabot-auto-merge.yml

Shadow mode — this check is informational only. When activated, changes to these paths will require approval from a maintainer.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Dependabot auto-merge GitHub Actions workflow to remove the gh pr review --approve step, avoiding failures when the repository setting “Allow GitHub Actions to create and approve pull requests” is disabled, while keeping auto-merge behavior unchanged.

Changes:

  • Removed the workflow step that attempted to approve eligible Dependabot PRs via gh pr review --approve.
  • Kept the existing “enable auto-merge for patch/minor (excluding GitHub Actions)” logic intact.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jeremy jeremy merged commit 46a580f into master Apr 29, 2026
24 checks passed
@jeremy jeremy deleted the ci/dependabot-auto-merge-drop-approve branch April 29, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants