Touch board when publication changes to bust JSON cache#2674
Merged
flavorjones merged 1 commit intoMar 9, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures board JSON responses don’t serve stale cached data after publishing/unpublishing by updating the board’s timestamp whenever a Board::Publication is created or destroyed.
Changes:
- Add
touch: truetoBoard::Publication’sbelongs_to :boardsoboard.updated_atchanges on publish/unpublish. - Ensures
json.cache! boardin the board JSON partial is re-keyed after publication state changes, allowingpublic_urlto appear/disappear correctly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Publishing or unpublishing a board didn't bust the `json.cache! board` fragment cache because `Board::Publication` didn't touch its parent board. The board's `updated_at` stayed stale, so subsequent GET requests continued serving cached JSON without `public_url`.
robzolkos
force-pushed
the
touch-board-on-publication-change
branch
from
5dc819b to
6e071b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
public_urlin subsequentGET /boards/:id.jsonresponsesjson.cache! boardwhich keys offboard.updated_at, but creating/destroying aBoard::Publicationnever touched the parent boardtouch: trueto thebelongs_to :boardassociation bumps the board's timestamp on publish/unpublish, busting the stale cacheFixes the missing
public_urlfield observed on hosted after #2663.