Show dropdown of protected app's paths for easy selection.#52
Open
jjatinggoyal wants to merge 4 commits into
Open
Show dropdown of protected app's paths for easy selection.#52jjatinggoyal wants to merge 4 commits into
jjatinggoyal wants to merge 4 commits into
Conversation
Author
|
@lewispb please review |
Author
|
@lewispb can you please take a look at this PR? |
Author
|
@lewispb just bumping this up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an option to pick paths for denying traffic from the protected app's available routes. Implements #39
Approach
After routes are loaded in the Protected app, it writes its available routes to the shared Redis instance. The Admin app reads the available routes for an application from the same shared Redis instance.
Users can still enter custom patterns by selecting
Nonein Application Path field.Note:
stimulusfor the small JS script, as I wanted to avoid addingstimulus-railsdependency.