Skip to content

Show dropdown of protected app's paths for easy selection.#52

Open
jjatinggoyal wants to merge 4 commits into
basecamp:mainfrom
jjatinggoyal:routes-list
Open

Show dropdown of protected app's paths for easy selection.#52
jjatinggoyal wants to merge 4 commits into
basecamp:mainfrom
jjatinggoyal:routes-list

Conversation

@jjatinggoyal

@jjatinggoyal jjatinggoyal commented Apr 27, 2025

Copy link
Copy Markdown

This PR introduces an option to pick paths for denying traffic from the protected app's available routes. Implements #39

Approach
After routes are loaded in the Protected app, it writes its available routes to the shared Redis instance. The Admin app reads the available routes for an application from the same shared Redis instance.

Users can still enter custom patterns by selecting None in Application Path field.

Note:

  1. I didn't use stimulus for the small JS script, as I wanted to avoid adding stimulus-rails dependency.
Create new route Index

@jjatinggoyal jjatinggoyal changed the title Show dropdown of protected app's paths for easy selection. Implements #39 Show dropdown of protected app's paths for easy selection. Apr 27, 2025
@jjatinggoyal

Copy link
Copy Markdown
Author

@lewispb please review

@jjatinggoyal

Copy link
Copy Markdown
Author

@lewispb can you please take a look at this PR?

@jjatinggoyal

Copy link
Copy Markdown
Author

@lewispb just bumping this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant