Prevent undefined reference error on ErrorString - #8739
Open
florann wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents custom bar load failures from blocking fallback to the default bar.
Changes:
- Guards access to the optional
errorString. - Preserves fallback through
failedBarId.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading a cloned/custom bar (kind: "bar") that fails required-property initialization throws a ReferenceError on the undefined errorString property, which prevents the automatic fallback to omarchy.bar from running. The result is no top bar at all.
This fix guards the errorString access with typeof, so a failed load falls back to the default bar gracefully instead of crashing.
Fixes the required-property failure in pluginBarLoader for third-party bar plugins.
Relates to #7418