Skip to content

Prevent undefined reference error on ErrorString #8739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
florann wants to merge 2 commits into
base: quattro
Choose a base branch
from
Open

Prevent undefined reference error on ErrorString #8739

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f7bf35
Prevent undefined reference error on ErrorString
florann Aug 28, 2026
70d81d1
Add test to bar-test
florann Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shell/shell.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ ShellRoot {
onActiveChanged: if (!active) shell.bar = null
onStatusChanged: {
if (status === Loader.Error) {
var detail = errorString && errorString() ? errorString() : ""
var detail = (typeof errorString !== "undefined" && errorString && errorString()) ? errorString() : ""
Comment thread
florann marked this conversation as resolved.
console.warn("bar option " + shell.activeBarId + " failed to load, falling back to " + shell.defaultBarId + ":", detail)
shell.failedBarId = shell.activeBarId
}
Expand Down