Prevent network address values from overlapping labels - #8741
Open
avk458 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents IPv4 values from overlapping adjacent labels in the network details grid.
Changes:
- Gives IP address and gateway values three-column spans.
- Places each value on its own row.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
Before
After
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Give the IP address and gateway values the remaining three columns in the network details grid. Each value now uses its own row.
Why
IPv4 addresses can exceed the width of one value cell and draw over the adjacent labels. This occurs in the stock panel at the default 12 px text size.
This uses the same full-width layout that #8683 applies to long IPv6 values, but fixes the existing IPv4 fields independently.
Testing
bash test/shell.d/network-test.sh