fix: set room instance variable in room direct destroy#12
Merged
monorkin merged 1 commit intoSep 6, 2025
Conversation
monorkin
approved these changes
Sep 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue #10
I think the issue could be caused by my last PR #9, where I override the before_action in the child controller (app/controllers/rooms/directs_controller.rb) to set the room instance variable in the edit method.
I'm new to rails and ruby, I just read on inheritance and before_action, i'm hesitant to add show in the child controller's before_action.
Please let me know if the current fix is adequate, I'm happy to learn more about and work more on this. Sorry about the problem caused by my last PR.