Add local TLS provider#99
Open
sled wants to merge 4 commits into
Open
Conversation
reesericci
approved these changes
Nov 16, 2025
reesericci
left a comment
reesericci
left a comment
There was a problem hiding this comment.
As the original author on the first PR, this looks great to me!
|
@kevinmcconnell does this PR address your concerns with #40? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking up from #40 where @ioquatix did most of the heavy lifting with the suggestions from @kevinmcconnell applied, i.e. I refactored the TLS providers to share a common interface. I also added some tests.
What could be optimized is caching the certificates inside of the
LocalTLSProvider, at the moment a new certificate is being issued on every request.