fix: broken label clearing - #10
Open
skaldebane wants to merge 1 commit into
Open
Conversation
`delete_trigger` was set to `false` for the label-clearing post, thus it currently does nothing at all, and it's impossible to clear these labels any other way. seems like it was broken since the code was refactored to add `delete_trigger` in the first place. this switches it to `true` for the clear post. preferably, the server should respond to "Appeal" events, but idk how to integrate with these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delete_triggerwas set tofalsefor the label-clearing post, thus it currently does nothing at all, and it's impossible to clear these labels any other way. seems like it was broken since the code was refactored to adddelete_triggerin the first place.this switches it to
truefor the clear post.preferably, the server should respond to "Appeal" events, but idk how to integrate with these.