Open
Conversation
* Expand assert_file_not_contains to allow an optional regex engine selection, to mirror assert_file_contains. * Change README to reflect this change. * Since there were no regex engine tests for assert_file_contains, I did not add any for my expanded assert_file_not_contains.
Author
|
Once this is approved, I will also expand the allowed regex engines in both assertions. I have found zgrep, zegrep, and zipgrep to be useful regex engines. I've modified Especially zipgrep, since a common modern method for creating application files is to ZIP up a collection of text files. This is used by EPUB, OpenDocument (ODT, ODS, etc), Office Open XML / OOXML (DOCX, XLSX, etc), and a few others where a simple I do wonder if there is a way to create tests for these engines. But it might require modifying the test environment more than you find acceptable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand assert_file_not_contains to allow an optional regex engine selection, to mirror assert_file_contains.
Change README to reflect this change.
Since there were no regex engine tests for assert_file_contains, I did not add any for my expanded assert_file_not_contains.