[codex] Log deploy push progress#582
Draft
utkarsh-dd wants to merge 1 commit into
Draft
Conversation
utkarsh-dd
force-pushed
the
codex/deploy-progress-logging
branch
from
b72edcb to
5bee533
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--jobs, push/load strategies, and operation countsremote.WithProgressinto deploy pushes and emit throttled aggregate byte progress on stderr once per minuteWhy
Large multi-deploy pushes can be quiet for a long time while blobs transfer, which makes it hard to tell whether the binary is running with the expected concurrency or making progress. This keeps stdout as the pushed ref output while adding human-readable stderr progress.
Validation
bazel test @rules_img_tool//cmd/deploy:all @rules_img_tool//pkg/push:all @rules_img_tool//cmd/deploymetadata:all //util:buildifier.checkbazel build @rules_img_tool//cmd/img