Add protoc-gen-validate v1.3.0#6780
Conversation
|
Hello @mering, modules you maintain (protoc-gen-validate) have been updated in this PR. |
|
@bazel-io skip_check unstable_url |
bazel-io
added
the
skip-url-stability-check
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds version 1.3.0 of the protoc-gen-validate module to the Bazel Central Registry. The changes are well-structured and correctly add the required files for a new module version, including MODULE.bazel, source.json, presubmit.yml, and a patch for compatibility with newer Bazel versions. My review identifies one issue regarding a redundant MODULE.bazel file within an overlay directory. Removing this duplication will improve the maintainability of the module definition. Please see the specific comment for details.
| module( | ||
| name = "protoc-gen-validate", | ||
| version = "1.3.0", | ||
| compatibility_level = 1, | ||
| repo_name = "com_envoyproxy_protoc_gen_validate", | ||
| bazel_compatibility = ['>=7.2.1'], | ||
| ) | ||
|
|
||
| bazel_dep( | ||
| name = "bazel_skylib", | ||
| version = "1.8.1", | ||
| ) | ||
| bazel_dep( | ||
| name = "gazelle", | ||
| version = "0.46.0", | ||
| repo_name = "bazel_gazelle", | ||
| ) | ||
| bazel_dep( | ||
| name = "protobuf", | ||
| version = "33.0", | ||
| repo_name = "com_google_protobuf", | ||
| ) | ||
| bazel_dep( | ||
| name = "re2", | ||
| version = "2024-07-02.bcr.1", | ||
| repo_name = "com_googlesource_code_re2", | ||
| ) | ||
| bazel_dep( | ||
| name = "rules_cc", | ||
| version = "0.2.13", | ||
| ) | ||
| bazel_dep( | ||
| name = "rules_go", | ||
| version = "0.58.3", | ||
| repo_name = "io_bazel_rules_go", | ||
| ) | ||
| bazel_dep( | ||
| name = "rules_java", | ||
| version = "8.16.1", | ||
| ) | ||
| bazel_dep( | ||
| name = "rules_proto", | ||
| version = "7.1.0", | ||
| ) | ||
| bazel_dep( | ||
| name = "rules_python", | ||
| version = "1.6.0", | ||
| ) | ||
| # -- bazel_dep definitions -- # | ||
|
|
||
| go_sdk = use_extension("@io_bazel_rules_go//go:extensions.bzl", "go_sdk") | ||
| go_sdk.download(version = "1.24.0") | ||
|
|
||
| go_deps = use_extension("@bazel_gazelle//:extensions.bzl", "go_deps") | ||
| go_deps.from_file(go_mod = "//:go.mod") | ||
| use_repo( | ||
| go_deps, | ||
| "com_github_iancoleman_strcase", | ||
| "com_github_lyft_protoc_gen_star_v2", | ||
| "org_golang_google_protobuf", | ||
| "org_golang_x_net", | ||
| ) | ||
|
|
||
| PYTHON_VERSIONS = [ | ||
| "3.9", | ||
| "3.10", | ||
| "3.11", | ||
| "3.12", | ||
| "3.13", | ||
| ] | ||
|
|
||
| python = use_extension("@rules_python//python/extensions:python.bzl", "python") | ||
|
|
||
| [ | ||
| python.toolchain( | ||
| is_default = python_version == PYTHON_VERSIONS[-1], | ||
| python_version = python_version, | ||
| ) | ||
| for python_version in PYTHON_VERSIONS | ||
| ] | ||
|
|
||
| pip = use_extension("@rules_python//python/extensions:pip.bzl", "pip") | ||
|
|
||
| [ | ||
| pip.parse( | ||
| hub_name = "pgv_pip_deps", | ||
| python_version = python_version, | ||
| requirements_lock = "//python:requirements.txt", | ||
| ) | ||
| for python_version in PYTHON_VERSIONS | ||
| ] | ||
|
|
||
| use_repo(pip, "pgv_pip_deps") |
There was a problem hiding this comment.
This file is an exact duplicate of modules/protoc-gen-validate/1.3.0/MODULE.bazel. According to BCR practices, the overlay entry in source.json identifies files by their content hash. Since modules/protoc-gen-validate/1.3.0/MODULE.bazel is a required file and has the same content, this file in the overlay directory is redundant.
To simplify the module definition and avoid file duplication, please remove this file and the parent overlay directory. The BCR tooling will use modules/protoc-gen-validate/1.3.0/MODULE.bazel to satisfy the overlay requirement in source.json.
References
- The BCR contributing guide indicates that files for an overlay are commonly placed in an
overlaydirectory, but the tooling identifies them by hash. When a required file at the version root (likeMODULE.bazel) has the same content and hash, the separate overlay file becomes redundant. Removing it simplifies the module definition. (link)
mmorel-35
force-pushed
the
protoc-gen-validate
branch
from
b738106 to
c57f8c0
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
protoc-gen-validate
branch
from
74727f8 to
9e9d81f
Compare
There was a problem hiding this comment.
Please create an upstream PR with this patch. Maintaining downstream patches accumulates to a lot of effort. Thanks!
There was a problem hiding this comment.
There is already one from @meteorcloudy in bufbuild/protoc-gen-validate#1325
meteorcloudy
added
the
presubmit-auto-run
bazel-io
left a comment
bazel-io
left a comment
There was a problem hiding this comment.
All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.
bazel-io
added
the
auto-merged
4 participants
No description provided.