Open
Conversation
chiragramani
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
chiragramani
force-pushed
the
ios_dylibs
branch
3 times, most recently
from
8784403 to
c084bd7
Compare
chiragramani
force-pushed
the
ios_dylibs
branch
from
c084bd7 to
0bdc8f5
Compare
Contributor
|
Wasn't ios_framework producing dynamic library already or am I not understanding the difference here? @chiragramani |
luispadron
reviewed
Apr 25, 2025
| ) | ||
|
|
||
| ios_dylib = rule_factory.create_apple_rule( | ||
| doc = "Builds a iOS Dylib binary.", |
Contributor
There was a problem hiding this comment.
Could we add more info here, primarily what is a good use case for this rule, etc. This isnt intended to be used in deps of other targets right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for ios_dylib, which closely follows the implementation of macos_dylib to ensure consistency across platforms.
One of our projectgen use-cases involves combining all Swift libraries into a single dynamic library. This was previously handled outside of Bazel, but with this addition, we now leverage Bazel to support the same use-case in a reproducible and maintainable way.