Closed
Conversation
14c9e1e to
ef7c367
Compare
Contributor
Author
|
PR now brought up to date with 9.0.2 |
Contributor
Author
|
Closing without merging as this functionality is now available as part of changes to support DRM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📺 What
Allows DASH manifests which specifies a metric reporting block in the following form;
to report to the endpoint.
🛠 How
Changes the Dash.js import to use
dashjsinstead ofindex_mediaplayerOnly, additionally addssetXHRWithCredentialsForType("DVBReporting", true)to allow cookies to be passed with any of these reporting requests by the place - this is required in order to ID the session.✅ Testing [Semi-optional]
Mock player expanded to include
setXHRWithCredentialsForTypemethod.Test Guidelines
Bundle size could change as a result of this PR.