Skip to content

fix(imsc): subtitle startup race condition #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eirikbjornr merged 1 commit into from
Mar 3, 2025
Merged

fix(imsc): subtitle startup race condition #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/subtitles/imscsubtitles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,8 @@ function IMSCSubtitles(mediaPlayer, autoStart, parentElement, mediaSources, defa
}

function isValidTime(time) {
return time >= 0
// A newly loaded video element reports currentTime as 0
return time > 0
}

function getCurrentTime() {
Expand Down
19 changes: 19 additions & 0 deletions src/subtitles/imscsubtitles.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,25 @@ describe("IMSC Subtitles", () => {
expect(LoadUrl).not.toHaveBeenCalled()
})

it("does not load segments when currentTime is zero", () => {
captions = [
{
type: "application/ttml+xml",
url: "mock://some.media/captions/$segment$.m4s",
cdn: "foo",
segmentLength: 3.84,
},
]

subtitles = IMSCSubtitles(mockMediaPlayer, true, targetElement, mockMediaSources, {})

mockMediaPlayer.getCurrentTime.mockReturnValue(0)

jest.advanceTimersByTime(UPDATE_INTERVAL)

expect(LoadUrl).not.toHaveBeenCalled()
})

it("stops loading all segments when the XML transform fails for some segment", () => {
fromXML.mockImplementationOnce(() => {
throw new Error("An error occured during transformation.")
Expand Down