Return support for em_http_request - #1103
Merged
Merged
Conversation
Koilanetroc
force-pushed
the
return-em-http-request-support
branch
2 times, most recently
from
August 4, 2025 11:20
62b081a to
cd49bd1
Compare
Contributor
Author
|
Seems like currently something is off with CI, I tested a dummy change(only changed a line in readme) and CI was red anyway, also failures seems to be unrelated to my changes. |
Koilanetroc
marked this pull request as ready for review
August 4, 2025 11:21
Contributor
Author
|
@koic, as I see recent PRs were merged by you, maybe you could have a look? |
|
It would be nice to get this merged. |
Collaborator
|
@Koilanetroc The CI issue has been resolved by #1107. Can you rebase with the latest master branch? |
Koilanetroc
force-pushed
the
return-em-http-request-support
branch
from
October 22, 2025 05:13
cd49bd1 to
178e965
Compare
Contributor
Author
|
@koic, done |
koic
reviewed
Oct 23, 2025
Comment on lines
+4
to
+7
| require 'curb' | ||
| require 'patron' | ||
| require 'typhoeus' | ||
| require 'em-http' |
Collaborator
There was a problem hiding this comment.
Ah, that’s my two cents. Can you reorder it as follows?
Suggested change
| require 'curb' | |
| require 'patron' | |
| require 'typhoeus' | |
| require 'em-http' | |
| require 'curb' | |
| require 'em-http' | |
| require 'patron' | |
| require 'typhoeus' |
Koilanetroc
force-pushed
the
return-em-http-request-support
branch
from
October 23, 2025 05:54
178e965 to
d9499e8
Compare
Collaborator
|
Thanks! |
|
@koic, do you know when releases to Ruby Gems usually happen? |
Collaborator
|
Yeah, I plan to release it today or tomorrow. |
Collaborator
|
WebMock 3.25.2 has been released. |
Owner
|
Thank you @koic 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In version 3.24.0 support for
em_http_requestwas dropped due to:The problem was addressed in igrigorik/em-http-request#354 and now cookiejar supports ruby 3.3+, it was added in this commit.
Therefore I'm returning back support for
em_http_requestwhich was disabled in #1070