testing feature branch - release v4 - #230
Closed
GailR wants to merge 55 commits into
Closed
Conversation
this file was generated locally (i.e. not from Shiny app)
|
added wrong file
…hub.com/bcgov/aqwarnings into test-aqwarnings-shiny-feature-v4-branch
These files were generated from the aqwarnings_shiny repo feature/release-v4 branch directly.
continued with burn ban end wildfire
Testing products from the shiny app "test_releasev4_aqwarnings_shiny" Specific features to review: - greek letters - SDM signature (not expected to work yet, issue has been filed) - accordion and cards - logos
- produced from shiny app based on aqwarnings_shiny feature/release-v4 branch
GailR
marked this pull request as draft
October 30, 2025 17:51
checking date, new markup in .md including hyperlink
checking - updated text and links in .md file, date (all files)
most recent updates - temporary url on .md files pointing to pdf (when burn prohibition issued) - end local emission advisories have options to end or continue burn prohibitions
GailR
changed the title
- table spacing when PM2.5 and PM10 issued - hyperlink to pdf
check - mu prints properly - inline alert including url
accordions cards inline alert
End warnings, check: - inline alert - accordions - cards (including widths) Issue warning, check: - card width at end of page
- burn prohibition end time was not printing previously
Member
Author
|
created for demo purposes, closing PR |
Member
Author
|
whoops, closed wrong PR - reopening this one for continued testing of v4 of the shiny app |
adding dummy bylaw parameter to yaml for testing
added dummy bylaw parameter to yaml
added dummy bylaw parameter to yaml
added dummy bylaw parameter to yaml
added dummy bylaw parameter to yaml
- sdm signature removed - minor formatting edits under "For additional information about air quality warnings" header
- removed block quote
testing spacing for mandatory emission reduction section
- removed code related to temporary work around (referencing PDF with SDM signature)
- made paste() sep = based on output file format; to improve line spacing - more formatting needed in future
- added missing header ("Follow your common sense) in local_emissions_issue.qmd
- fixed card formatting
- updated urls
- formatted output file names to <date><location><ice><warning type>
The air quality warnings table was populating incorrectly. Testing with updated YAML parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these files were generated locally (i.e. not from aqwarnings Shiny app)