Add City of Vancouver MSDiLOA (dev) OCA Bundle - #197
Conversation
Signed-off-by: Mathieu Glaude <mathieu@northernblock.io>
|
@mathieuglaude thank you. I am not sure why the script reorders the entries, I will have to look into it. That being said, I would let it add the entries even with the reordering so we know the process is consistent. |
|
Almost all looks good, although you can use this as is. The two index files that are included here are auto-generated on merging, so no need to include them. They should probably be removed from the repo as they are not the "source of truth" -- the files generated on merging and stored in the gh-pages branch are that. It was on my to do list that I didn't get to before leaving the team. Other than that -- all good. The attribute sorting is done by the Excel-to-Bundle script that we didn't create. I agree that it should not be done, and could be altered. What I would really like to see is removal of the Excel file in favour of YAML, but we're not there yet. That is a tradeoff between (a little) harder for the Bundle Creator (vs. using Excel), but easier for the rest of the GitHub process to see exactly what is happening. I don't have the power to approve anymore, but :+1 from me. |
@krobinsonca, @esune
Adds the City of Vancouver — Municipal Services Digital Letter of Authorization (MSDiLOA) OCA Bundle for CANdy Dev, following the same structure as the existing City of Vancouver Rental Property Business Licence bundle.
OCABundles/schema/CityOfVancouver/dev-municipal-services-digital-letter-of-authorization/authorized_services_summary(primary) +authorized_location_short_address(secondary), reusing the CoV logo/background/colours.YWnESLB4SH275SMNvaJJ1L:2:Municipal Services Digital Letter of Authorization:1.1— domain/39764YWnESLB4SH275SMNvaJJ1L:3:CL:39764:Municipal Services Digital Letter of Authorization— domain/39765genBundle.sh(OCA Excel Parser 1.2.1) and validated againstOCABundles/validators/schema.json.Note on the index files: I added the two new entries to
ocabundles.json/ocabundleslist.jsonby hand (minimal diff). Re-runningscripts/gen_ocabundlesjson.shcurrently rewrites many unrelated entries (trailing-whitespace + reordering) against the committed index, so I kept it clean — happy to run the full generator instead if you'd prefer.