feat(ias): move person bundle to IAS digital-services-card (prod) - #211
Draft
esune wants to merge 1 commit into
Draft
feat(ias): move person bundle to IAS digital-services-card (prod)#211esune wants to merge 1 commit into
esune wants to merge 1 commit into
Conversation
- Add digital-services-card OCA bundle under IAS (prod identifier) - Remove standalone person bundle (bcgov-digital-trust/person) - Regenerate OCABundle.json from updated OCA.xlsx and branding.json - Update ocabundles.json, ocabundleslist.json, and mkdocs.yml Signed-off-by: Emiliano Suñé <2395873+esune@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR migrates the existing “Person” OCA bundle into the IAS “digital-services-card” bundle (prod identifier) and updates registry/index files and docs so consumers resolve the cred def to the new bundle location and name.
Changes:
- Added a new IAS
digital-services-cardOCA bundle (with updated meta/branding overlays). - Removed the standalone
bcgov-digital-trust/personbundle documentation entry and repointed bundle indexes (ocabundles.json,ocabundleslist.json) to the new IAS path. - Updated MkDocs navigation and reorganized/expanded City of Vancouver PROD MSDiLOA entries.
Reviewed changes
Copilot reviewed 7 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
ocabundleslist.json |
Repoints the RGjWbW1...:Person cred def to the IAS digital-services-card bundle and adjusts some City of Vancouver PROD entries. |
ocabundles.json |
Updates ID→bundle path mapping to the new IAS digital-services-card bundle and reorders City of Vancouver PROD entries. |
mkdocs.yml |
Adds IAS digital-services-card README to docs nav; adds City of Vancouver PROD MSDiLOA README; removes the old person README entry. |
OCABundles/schema/bcgov-digital-trust/person/README.md |
Removes the standalone “person” bundle README content. |
OCABundles/schema/bcgov-digital-trust/IAS/digital-services-card/README.md |
New documentation for the IAS digital-services-card bundle. |
OCABundles/schema/bcgov-digital-trust/IAS/digital-services-card/OCABundle.json |
New/updated bundle contents (meta overlays rename to Digital Services Card, support URL, issuer fields, branding URLs). |
OCABundles/schema/bcgov-digital-trust/IAS/digital-services-card/branding.json |
New branding config pointing to the IAS asset URLs. |
OCABundles/schema/bcgov-digital-trust/IAS/digital-services-card/testdata.csv |
Adds test data for the new bundle. |
OCABundles/schema/bcgov-digital-trust/IAS/digital-services-card/bc-logo.jpg |
Adds a logo asset for the new bundle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+59
to
+60
| { "id": "R12pguaP3VF2WiE6vAsiPF:2:Municipal Services Digital Letter of Authorization:1.1", "org": "City Of Vancouver", "name": "City of Vancouver PROD Municipal Services Digital Letter of Authorization", "desc": "A schema for a \"Municipal Services Digital Letter of Authorization \" issued by the City of Vancouver. The MSDiLOA represents a digital authorization for a person to apply for or access municipal services on behalf of another person or a business.", "type": "schema", "ocabundle": "OCABundles/schema/CityOfVancouver/prod-municipal-services-digital-letter-of-authorization/OCABundle.json", "shasum": "02c82ab24bf93a92f70889d8dd34c78719703feb7d0c9967d89c5d5fb0208e1c" }, | ||
| { "id": "R12pguaP3VF2WiE6vAsiPF:3:CL:8117:Municipal Services Digital Letter of Authorization", "org": "City Of Vancouver", "name": "City of Vancouver PROD Municipal Services Digital Letter of Authorization", "desc": "A schema for a \"Municipal Services Digital Letter of Authorization \" issued by the City of Vancouver. The MSDiLOA represents a digital authorization for a person to apply for or access municipal services on behalf of another person or a business.", "type": "credDef", "ocabundle": "OCABundles/schema/CityOfVancouver/prod-municipal-services-digital-letter-of-authorization/OCABundle.json", "shasum": "02c82ab24bf93a92f70889d8dd34c78719703feb7d0c9967d89c5d5fb0208e1c" }, |
Contributor
There was a problem hiding this comment.
Extra space in the quote I guess
"Municipal Services Digital Letter of Authorization \"
Member
Author
There was a problem hiding this comment.
This is something that derives from that bundle's README file (I believe). Will have to double check, it would be an unrelated change either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolvces #195
Related to bcgov/DITP#153
leaving in draft mode until ready to apply