Conversation
There was a problem hiding this comment.
Pull request overview
Adds “IS review” and “RS review” as approver-only subset filters under “Pending HQ review” on the Submit page, including UI indentation and consistent badge-removal behavior, and wires the filtering logic to season approval flags returned by the API.
Changes:
- Adds approver-only indented status filter options (“IS review”, “RS review”) and parent/child selection rules in the Submit page status MultiSelect.
- Updates filtering logic to support the new subset filters, using
informationSvcApproved/reservationSvcApproved. - Extends
/parksAPI payload to include the approval-flag fields needed by the frontend.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/router/pages/SubmitPage.jsx | Adds approver-only subset status options and enforces parent/child checkbox behavior in the status filter. |
| frontend/src/lib/submitPageFilters.js | Implements status matching logic for the new subset filters. |
| frontend/src/constants/seasonStatus.js | Introduces filter-only status constants and adds them to labelByValue. |
| frontend/src/components/MultiSelect.jsx | Extends onInput to pass metadata and supports indented option rendering. |
| frontend/src/components/FilterStatus.jsx | Keeps badge removal consistent with the parent/child status selection rules. |
| backend/routes/api/parks.js | Exposes season approval flags required for subset filtering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Rebasing onto |
duncan-oxd
left a comment
There was a problem hiding this comment.
Cool! I realized there's a logical issue with the dual approval process that we might need to go over together and/or check with Amanda, but the UI stuff all looks great.
A few nitpicks about variable names and comments to consider in the meantime 👍
duncan-oxd
left a comment
There was a problem hiding this comment.
Looks great! I had one request about changing a .forEach to a .map for clarity, and a note for both of us about rebasing when we merge. Otherwise it looks good!
I think the Sept 24 stuff will be okay to merge later this week 👍
Jira Ticket
CMS-1940
Description