5001 BCCR remote errors - #5106
Open
gdalcengio wants to merge 2 commits into
Open
Conversation
gdalcengio
commented
Aug 18, 2026
gdalcengio
commented
Contributor
- feat: display remote BCCR endpoint error and update endpoint to match
- test: update BCCR account_id tests and display tests
gdalcengio
force-pushed
the
5001-BCCR-remote-errors
branch
from
August 18, 2026 21:17
a3e320a to
6e10023
Compare
pbastia
approved these changes
Aug 20, 2026
pbastia
left a comment
pbastia
left a comment
Contributor
There was a problem hiding this comment.
A couple of nitpicks, looks great! Approved once you've added the tiny changes
| try: | ||
| account_details = bccr_service.get_account_details(account_id=account_id) | ||
| trading_name = getattr(account_details, "trading_name", None) if account_details else None | ||
| return 200, {"bccr_trading_name": trading_name, "has_remote_bccr_errors": False} |
Contributor
There was a problem hiding this comment.
Suggested change
| return 200, {"bccr_trading_name": trading_name, "has_remote_bccr_errors": False} | |
| return 200, {"bccr_trading_name": trading_name} |
We can probably omit that flag, it's already optional on the frontend. Just less code!
|
|
||
| @router.get( | ||
| "/bccr/accounts/{account_id}/compliance-report-versions/{compliance_report_version_id}", | ||
| response={200: dict, custom_codes_4xx: Message}, |
Contributor
There was a problem hiding this comment.
We should use this PR to specify a ninja schema, it's missing:
class BCCRAccountDetailsSchema(Schema):
bccr_trading_name: str
has_remote_bccr_errors: Optional[bool]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.