chore: Update clamav 1 4 6 - #1947
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the ClamAV container/image and Helm chart configuration to move away from logging directly to /dev/stdout (which crashes clamd under OpenShift/CRI-O symlink resolution) while bumping the packaged ClamAV version.
Changes:
- Bump ClamAV RPM version to
1.4.6and update chartappVersion. - Redirect clamd/freshclam logging to real log files and stream them back to stdout via a launcher script.
- Force dev deployments to always re-pull the image to avoid node-side cache reuse.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| clamav/run.sh | New launcher that tails log files to stdout and runs freshclam then clamd. |
| clamav/Dockerfile | Bumps ClamAV version, adds launcher script, and switches container CMD to use it. |
| clamav/config/freshclam.conf | Switches update logging from /dev/stdout to /var/log/clamav/freshclam.log. |
| clamav/config/clamd.conf | Switches clamd logging from /dev/stdout to /var/log/clamav/clamav.log with rationale. |
| clamav/charts/clamav/values-dev.yaml | Sets clamav.imagePullPolicy: Always for dev. |
| clamav/charts/clamav/templates/configmap.yaml | Updates generated clamd/freshclam configs to use file logging (and whitespace/formatting tweaks). |
| clamav/charts/clamav/Chart.yaml | Updates Helm appVersion to 1.4.6. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
this change makes the helm's configmap the source of truth while still working locally with docker run testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
our chefs-clamav deployment is constantly being scaled to zero since we haven't been maintaining it. when trying to deploy version 1.4.5 which was built previously, we get the following error:
I have tried commenting out the LogFile, but the error still persists. this change will attempt to redirect the logs to a real file.
Type of Change
build (change in build system or dependencies)
This is a breaking change because ...
clamav might not work.. at least in dev, but we're having our clamav being scaled down anyways so we need to resolve this
Checklist
Further comments