Add Navbar component - #676
Closed
mkernohanbc wants to merge 27 commits into
Closed
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
mkernohanbc
added
the
react-components
* fail storybook and unit tests on console.warn * add aria-label to NumberField+Select example * spy on console warnings earlier
* automated migration * add types and update figma config * refactor migrated mappings Co-authored-by: Copilot <copilot@github.com> * remove legacy *.figma.tsx files * reformat Modal and NumberField files * handle edge cases in AlertBanner and ProgressBar * add build script to test_react_component_library * exclude figma.ts files from rollup and build --------- Co-authored-by: Copilot <copilot@github.com>
* add GitHub Packages publishing step Co-authored-by: Copilot <copilot@github.com> * refactor publish GHA to handle publishing to npm and GH registries in separate jobs Co-authored-by: Copilot <copilot@github.com> * assign write permissions at job level * update workflow name * set registry-url at publish instead of in setup-node --------- Co-authored-by: Copilot <copilot@github.com>
* decompose workflow-level permissions * use npm ci instead of npm install * Revert "use npm ci instead of npm install" This reverts commit 288cd9c.
* apply focus styling more consistently * handle simultaneous hover and focus in text inputs
* add sizing logic to AlertBanner * add AlertBanner sizing to Storybook * add alignment prop to AlertBanner * add alignment controls to Storybook * rename alignment prop * add test suite
* refactor design tokens publish workflow to support publishing to GitHub Packages * add read permissions to each job * fix auth and labelling issues * add secondary setup-node step
* Code Connect v1.4.5 * Storybook v10.4.0 * Vitest v4.1.7 * types/node and types/react * ESlint v10.4.0 * Vite v8.0.13 * typescript-eslint v8.59.4 * jsdom v29.9.1 * Playwright v1.60.0 * Rollup v4.60.4 * vitejs/plugin-react v6.0.2 * regenerate package-lock
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
… into feature/navbar
Contributor
Author
|
Closing this PR, moved WIP to #693. |
mkernohanbc
added a commit
that referenced
this pull request
Jun 23, 2026
* fork WIP from #676 * refactor Navbar children to render as a semantic list * remove comment * formatting * harden stories and tests * docs typos * add and document ariaLabel prop * update Code Connect logic * remove branching logic for function children * rename Navbar to Subheader * remove redundant Popover * add Menu to size allowlist * allow size to propagate to nested components * formatting * Revert "formatting" This reverts commit 4907781. * Revert "allow size to propagate to nested components" This reverts commit c06c8dc. * Revert "add Menu to size allowlist" This reverts commit c324f16. * remove remaining child sizing logic * add explanatory comment to ariaLabel prop * cleaning up styling * remove react-aria from classNames * tweak separator sizing * fix failing test * increase gap and horizontal padding to match figma spec * tweak sizing logic * tweak storybook ordering * update Code Connect mapping for Subheader * Update copy in example story Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Update test case Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * improve key handling in list Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR separates out the Navbar work-in-progress from #647, with changes:
<nav>elementAdditional work required, leaving this in draft for now.