Test workflows: set correct download path for build artifacts - #763
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the two temporary “test publish” GitHub Actions workflows to download build artifacts into the directories where the subsequent npm publish steps expect the package contents to exist, addressing the job failure observed in the test workflows introduced in #762.
Changes:
- Set
actions/download-artifactpathfor the react components test workflow to download intopackages/react-components. - Set
actions/download-artifactpathfor the design tokens test workflow to download intopackages/design-tokens/dist. - Apply the same artifact download path fix across all publish simulation jobs (
next/latest, npm/GitHub Packages) in both workflows.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test_publish_react_component_library.yaml | Downloads the react-components build artifact into packages/react-components so npm publish runs against the expected working directory. |
| .github/workflows/test_publish_design_tokens.yaml | Downloads the design-tokens build artifact into packages/design-tokens/dist so npm publish runs against the expected working directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix this job failure in the test workflows from #762: https://github.com/bcgov/design-system/actions/runs/28268823077/job/83761783124