Release/2.0.x - APTS replacement MVP - #1333
Draft
bferguso wants to merge 101 commits into
Draft
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Fix a couple CMS bugs and improve testing coverage * Fix negation bug and introduce scenario and snapshot testing * black and prettier formatting * Resolving CI test errors (#1313) Changes to get CI back in the green * Resolving CI test errors * Delete stale management command --------- Co-authored-by: brett <brett@qedsystems.ca>
* Change node label to match intended use * Align site visit permitted flag with label changes
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bferguso
marked this pull request as draft
April 7, 2026 02:52
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
* Update keywords, better API error handling * Add missing attribute, fix pattern logic * Revert map.js changes --------- Co-authored-by: brett <brett@qedsystems.ca>
* Initial cut of Permit Application resource model * Add migration placeholder (#1332) * Add migration placeholder * Initial cut of external permit workflows * Resolving turf conflicts * Resolving ts errors * Resolving ts errors * Update package lock * Fix prettier format * Update Permit Application resource model for 1282 fields, minor workflow tweaks * Add workflow step 3, update graph, update package-lock * Rough in Steps 4-7 * Remove hyphen from node name * Add personnel section
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Initial cut of Permit Application resource model * Add migration placeholder (#1332) * Add migration placeholder * Initial cut of external permit workflows * Resolving turf conflicts * Resolving ts errors * Resolving ts errors * Update package lock * Fix prettier format * Update Permit Application resource model for 1282 fields, minor workflow tweaks * Add workflow step 3, update graph, update package-lock * Rough in Steps 4-7 * Remove hyphen from node name * Add personnel section * initial layout * Added Arch Assessment Details Section 3 - Methods * Added Arch Assessment Details Sections 4 - 7 * step5 backfill * step6 backfill * step7 backfill * step 8 * setp9 * step1 Acceptance Criteria * step10, 11, 12, and 13 text pages * Fix alias in step 5 * destination repository update * step14 sign off, display steps done will need node update * style consolidation * Start of admin info, additions to legal & consent * final node integration and certify checkbox * test for current date value * updates to the setup README * Commit package-lock.json outcome * Bump and loosen component lab version requirements --------- Co-authored-by: brett <brett@qedsystems.ca>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Adds the permit/application requirement and requirement submission models and links them to a permit application. * Try to resolve CI ES field limit configuration issue * Blank out sourcebranchpublication_id, try to fix CI max field limit configuration issue * Move requirement dates into Permit Requirement resource model, add target processing time to requirement.
…th helper, override export_results behaviour (#1425) LGTM!
* Adds the permit/application requirement and requirement submission models and links them to a permit application. * changed the route to workflows just to see my dashboard will need to be changed back * first cut with mock data * Try to resolve CI ES field limit configuration issue * Blank out sourcebranchpublication_id, try to fix CI max field limit configuration issue * search matches now highlighted on card * rearranged filter bar and now showing number of projects * Move requirement dates into Permit Requirement resource model, add target processing time to requirement. * priority cards now sort to the top, card body accepts HTML, new menu of filters off the search to sort cards * filter menu reorg to alphabetical, also added 'assigned to' * new schemas and backend for permit requirement and submission requirement * update to match updated card titles change * splash page edits * bullet point fix * new images, and removing old BCRHP images * removing old BCRHP images * new mounting point for internal dash * add new route for dashboard with mock data for now, update readme # Conflicts: # bcap/views/api.py * Fix: set scripts to executable mode * arrows on the filter menu to change sort from ascending to descending * integrated new backend API call to dash * Refresh package lock * Fix black format * Remove unused AuthTestHelper class * Fix bad conflict merge --------- Co-authored-by: brett <brett@qedsystems.ca> Co-authored-by: Travis Semple <travis8814@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Add jupyter docker config, bump black version to 26.3.1, remove arches version suffix in docker containers and images, add ability to debug python in docker using PyCharm * Add BCAP data exploration to layout strategy to add arches controlled lists for BCAP * Fix black format issues for 26.3.1 * Updates to support multiple platforms, tweak README * Disable debug and platform configs by default
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* remove monkeypatch and add migration * black * allow a small drop * Update pyproject.toml
…1589) * wire up to arches zod validation * update schema * add two folders to check out * use codegen to generate other verbs than GET * clean up + unit test for arches_urls.htm * allow FE CI to go a little bit below 0.5 tolerace before failing * Regen, add in bcap message
…1596) * Process Requirement resource model refinement * clean up before creating three new resources * remove inspection and investigation high level * Fix BCAP Message - add recipient, repoint semantic to resource-instances * fix unit test * move out 3 branches, create 3 new resources Alteration, Inspection, Investigation, modify Permit Application * move into message content * add Investigation / Alteration / Inspection to the config * Add in identification fields * add in identification --------- Co-authored-by: Travis Semple <travis8814@gmail.com>
…al work (#1598) * permit details first cut * removed application number input field and added a dummy so backend can generate the number * review page refactor and new ReviewSummary component * removed extra fields from permit application * refactoring API calls out to seperate API file * refactoring and tests * blocking out files for inspection workflow * draft cap font fix * Remove redundant API resource URLs * Use bcgov version of the zod validation library * small fixes for date datatype, clean up schema that's not used * add in memory for the tab state * feedback fixes + refactors * add in validation * lint * clean up investigation * add in investigation draft to dashboard * add in delete for now for draft, more backend unit test coverage, make sure investigation deletes draft * prettier * coverage * fix coverage --------- Co-authored-by: brett <brett@qedsystems.ca> Co-authored-by: Travis Semple <travis8814@gmail.com>
* 1354 - guard against arch sites with no geom node, add tests * 1353 - Treat site visit description as HTML * 1457 - Break out permit details table * 1457 - Fix TS errors and warnings * 1459 - Set default site visit role * 1257 - Remove redundant Arch Site authority nodes, and sections from details page * 1257 - Commit outcome of OpenAPI, Zod schema and alias regeneration * Add missing generated views, fix requirement submission slug, regenerate views and zod schemas * Rerun regenerate_api with updated arches-zod-validation * Rerun regenerate_api with updated arches-zod-validation branch * Move layered business schema types outside of generated dir * Revert unintended map styling change
* initial changes for backend route * Add process requirement stubs, investigation_project_type collection * changes for frontend flow * Get modules working in the backend and frontend wired up to the real routes * Potential fix for pull request finding 'CodeQL / Uncontrolled data used in path expression' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * fix user path * revert primevue-theme-global * regen properly * increase test coverage, add in descriptor --------- Co-authored-by: brett <brett@qedsystems.ca> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* 1396 - Make site visit edit type list same as arch site edit type * 1410 - Add site visit boundary types * 1270 - Update boilerplay and placeholder text * 1605 - Set node widget back to register-type-widget
* 1027 - Add unprotected area types dev - Add outcome of npm install * 1027 - Add unprotected area types LOV * Fix prettier format
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Fix unprotected area type node order * Increment version to 2.0.0a17 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* BCAP Messaging backend base commit * fix for unit test database * update toml and test_settings * lint * Clean up routes and add in read date PATCH * DRF pairs GET and PATCH together intentionally, use the PatchedBCAPMessageWritable to fix type issues * move back to main * Add comment and fix up check for migration
Bug type is missing somehow
Added a section for actual behaviour (as opposed to expected)
Merging for sprint review - will read more carefully after. * 1027 - Make unprotected areas 1:m * Add borden number tests for upstream failures Add permit application filing_type, associated controlled list and update unit tests to align Rename initial workflow title to support BT changes * Fix black format * Fix lost site boundary map styling * 1616 - Local patch to resolve CSV export issue * Rework filing module structure + Module management build out + Process Requirement Template editor (#1620) Merging to cut new release for sprint demo. Will read through more carefully after. * Update issue templates to add Bug Bug type is missing somehow * Update issue templates for Bugs Added a section for actual behaviour (as opposed to expected) * Rework filing module structure. * rename fields, add aliases * messaging system first cut * removed extra message cards and added props for notification numbers * re pointing imports * moving load messages to API * moving out types and API cleanup * moving loadRecipients API call to API * updated onClick tests * initial run at modules and having process requirements able to be edited * tests for QuestionDialogExternal * lint + unit test fixes * add in unread_messages to external * fix arches component lab * pin higher * lets try 1a13 --------- Co-authored-by: Sergey Popov <sergey@popovconsulting.ca> Co-authored-by: Travis Semple <travis8814@gmail.com> Co-authored-by: Philip Hansen <philip.pt.hansen@gmail.com> --------- Co-authored-by: Sergey Popov <sergey@popovconsulting.ca> Co-authored-by: Travis Semple <travis8814@gmail.com> Co-authored-by: Philip Hansen <philip.pt.hansen@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* some code clean up * Backend model changes * docker changes to not use root * more data model changes * Backend changes for module summary * fix document_submission * minor changes + contributor changes * minor frontend * add in submission type * Internal dashboard FE * Fix font + add in submisison type + small tweaks * restyle about step * include submission_type tests * api changes for update module and fetch contributors for resource * base module changes + restyling with stepper css * lint * submission dashboard, loader, unit tests, add in type, modules * fix internal dashboard card * internal dash * submission detail changes * permitModule changes * more changes for drafts also styling etc * add in extra fields so our creation works * Add in dedicated routes to mark module as satisfied and requirement as satisfied (because sometimes they aren't just checklists) * fix width again * clean up * test fixes * unit test fixes * more unit test fixes * prettier * unit test warning fixes + styling tweaks + small backend fix * fix styling for add checklist
* upgraded messaging to include all the threads on a permit application * updated tests * added view message button to all modules in permit details and a context prop for the topic * more tests / testing fix * adding messaging button to accordions * bug fixes * bug fix in the API * merge fixes * adding messaging to new accordians * quick bug fix * testing fix * fixes from comments * removing message_response, no longer in the model
… Submission Review & BCAP File Upload (#1636) * rename to workflow drafts throughout the app and in arches * Initial rough cut of NOPI structure (#1635) * fix definition * fix button text * a couple more renames * lint * small changes * more changes for rename * use enum * point to new list for message_type * clean out unfinished modules * Refactor into WorkflowStepper * Clean out methods, recordings, collections * Refactor the BaseModule to use WorkflowStepper * Clean out submit app, can look at this in source control it's dead code * BCAP archived by * move components to folders so they are more organized * text change * fix from moving files * add in unarchive on a reply * fix some of the paths * fix mock path * lint * add in generate types to so we don't need to infer * Use the types.gen.ts * lint * remove purple * fix button -> Button * remove stub * bcap messaging changes + sync with release/2.0.x * Put in View Submission * small tweak --------- Co-authored-by: Brett Ferguson <brett@qedsystems.ca>
* Initial cut of DataBC views - WIP * Tune final view for business requirements * Fix black format, add black jupyter dependency * Generate the node alias functions and commit baseline fo the get_map_attribute_data function * Partial migration to use alias->uuid functions * Complete migration to use alias->uuid functions * Complete migration to use alias->uuid functions * Minor tweaks to get_map_attribute_data functon * Fix migration dependencies * Split out sql objects to be managed by django_sql_mgrations, add generation command * Add spec files and mv scripts for hca_permit, publication & repository graphs * Fix publication LOV to use reference datatype, fix black format * Inital cut of databc views for RAAD review * Add missing sql file * Try fixing publication JSON - remove trailing commas * Remove explicit database and schema references in map attribute data function * Fix unit test * Run black on generated spec files, add unit tests * Fix black format * Created unit test for outdated management command * Move databc views to subdirectory, remove comment to outdated script
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
adding UAT feedback template
* expose drafts to staff, put in save and exit button for draft, allow staff to view drafts for editing * Add in workflow for permit app that points to itself as a workflow * Permit app workflow added in Submission/Messages button correct level - Process Requirement level Breadcrumbs /bands for Edit / Complete Checklist Split CompletedModules into folder View Arches - Icon for arches core Search looking icon - View Arches icon = Internal Dashboard * Filter by tiles with Messages internal dashboard Use dropdown list for actions - Edit Checklist put it in dots on Filing Summary Wire in unread counts for Drafts on backend Wire in external dashboard draft call, wasn't wired Drafts filter for External dashboard * small fix for sorting bar and requirementrow * put in section or step resume for draft * optimize * permit package reload command * rewrite bcap message service proper, split out question dialog * implement assignee, get grid system working for dashboard, make band a bit more fluid without having to reload * back to filing summary button for checklist, just in case * fix draft issues not showing investigation, also not refering to the parent * Clean up sorting bar, fix blank assignee for staff * clean up * make vertical spacing consistent for both screens * optimization for internal * more tweaks * lint * expanded draft functionality * more clean up * lint * code clean up * lint * Wire in submission Company Projects, wasn't wired for some reason - more unit tests * front end unit tests * slim down unit tests * more unit tests for coverage * unit test coverage * clean out redundant comments * fix performance for unit tests * unit test optimization * unit test fixes + optimizations * update drafts so it uses same gen spec as creating the modules themselves, drafts use one large call to grab all drafts regardless of slug, update spec, use Typescript types, some typescript kung fu * remove reload_permit_package + own_data_filter * clean up + regenerate types + parentId query param for drafts + performance fixes for internal + unit test * prevent drift by using the same structure from our codegen * small change in order * revert arches-queryset cache * lint * lib update for docker
* expose drafts to staff, put in save and exit button for draft, allow staff to view drafts for editing * Add in workflow for permit app that points to itself as a workflow * Permit app workflow added in Submission/Messages button correct level - Process Requirement level Breadcrumbs /bands for Edit / Complete Checklist Split CompletedModules into folder View Arches - Icon for arches core Search looking icon - View Arches icon = Internal Dashboard * Filter by tiles with Messages internal dashboard Use dropdown list for actions - Edit Checklist put it in dots on Filing Summary Wire in unread counts for Drafts on backend Wire in external dashboard draft call, wasn't wired Drafts filter for External dashboard * small fix for sorting bar and requirementrow * put in section or step resume for draft * optimize * permit package reload command * rewrite bcap message service proper, split out question dialog * implement assignee, get grid system working for dashboard, make band a bit more fluid without having to reload * back to filing summary button for checklist, just in case * fix draft issues not showing investigation, also not refering to the parent * Clean up sorting bar, fix blank assignee for staff * clean up * make vertical spacing consistent for both screens * optimization for internal * more tweaks * lint * expanded draft functionality * more clean up * lint * code clean up * lint * Wire in submission Company Projects, wasn't wired for some reason - more unit tests * front end unit tests * slim down unit tests * more unit tests for coverage * unit test coverage * clean out redundant comments * fix performance for unit tests * unit test optimization * unit test fixes + optimizations * update drafts so it uses same gen spec as creating the modules themselves, drafts use one large call to grab all drafts regardless of slug, update spec, use Typescript types, some typescript kung fu * remove reload_permit_package + own_data_filter * clean up + regenerate types + parentId query param for drafts + performance fixes for internal + unit test * prevent drift by using the same structure from our codegen * small change in order * revert arches-queryset cache * lint * lib update for docker * Add in a way to automatically goto the process requirement when clicking from the internal dashboard * use data classes instead of dicts for the serializers, this will make typechecking detect code drift * re organize workflow drafts as per Brett's suggestion also add in owning organization that we can expand to a list in the future * refactor contributor service, split it into organization and contributor service * contributor service moves cont * Move draft_payload into it's own node so we can avoid writing audit log for it * add view in arches at the module level * small service moves * refactor common code * resource id use const * codegen * refactor to use WorkflowDraft for dashboard * add in owning organization changes for permit app/drafts * narrow down our views * toml * Add in filtering for company now, split the external dashboard into filings and drafts * unit tests cover draft by associated organizations * unit test addition + unit test clean up * clean up is internal for drafts * refactor common code * refactor parts of unit tests clean up * code issue fix * unit test optimizations * code cleanup * lint * cleanup * cleanup duplication * this unit test is already covered by unit/test_group_filter.py * fix same org different creating user case * tweaks for visibility * move over api call to proper file * clean up unit tests * fix arches override, fix warning for search * Fix assignee contributor lookup for BCAP messaging * Add in changes to facilitate audit log behaviour * update to isAuthenticated for some routes * add in CI check for API codegen * remove codegen check * Brf/feat/add management for refresh permitting (#1671) * Interim commit * Interim commit * Add unit tests, delete all cnw rows * Align controlled list uris with https://localhost/bcap prefix Add migration to give Submitter group access to external dashboard * Fix Publication.json formatting * Fix skos file * Fix black format * Fix resource instance node search strings * fix message counts * lint * Fix messaging for two users, still issues with multiple users * clean up * move over to vmodel instead of update * Add unit test for graph searchString validity (#1672) * Add unit test for graph searchString validity. Fix Publication and Document Submission resouce models * Fix resource model format * lint * fix bcap message --------- Co-authored-by: Travis Semple <travis8814@gmail.com> --------- Co-authored-by: Brett Ferguson <brett@qedsystems.ca>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…rnal/External Cards and filing summary (#1687) * Fix initial validation, devmode = false, devmode was enabled to bypass validation * Add in organization to internal/external dashboard cards also on the filing summary page * Move datatype factory into initialize, so we don't need a unit test wide mock that depends on import order * remove comma replacement * new descriptor types * remove devmode and some clean up * use new format, don't stub ProjectCard * clean up * use bcgov/arches-component-lab#v0.0.1a13-bcgov use github:bcgov/bcgov-arches-common#ts/bugfix/general_fixes * descriptors for contributor * function manager give ability to reindex * Point back at release/2.1.x of bcgov-arches-common --------- Co-authored-by: brett <brett@qedsystems.ca>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.