Company Project Visibility by seeker25 · Pull Request #1657 · bcgov/nr-bcap

seeker25 · 2026-08-05T19:35:11Z

Internal dashboard takes you to the requirement clicked on
Add in company field for draft filing / permit application
Workflow Draft graph rework
Rewrite Workflow Draft Services to use arches-querysets
Remove add modules for staff (needs discussion)
Company project visibility (users can see all projects for their company)
Make external dashboard 2 tabs -> Filings and Drafts, and then add a checkbox that works for either that would expand the list to the ones the company owns
Small filing summary CSS tweaks
Unit test refactor a bit

Relies on:
bcgov/arches-zod-validation#5

…staff to view drafts for editing

Submission/Messages button correct level - Process Requirement level Breadcrumbs /bands for Edit / Complete Checklist Split CompletedModules into folder View Arches - Icon for arches core Search looking icon - View Arches icon = Internal Dashboard

Use dropdown list for actions - Edit Checklist put it in dots on Filing Summary Wire in unread counts for Drafts on backend Wire in external dashboard draft call, wasn't wired Drafts filter for External dashboard

…a bit more fluid without having to reload

…parent

…ore unit tests

seeker25 · 2026-08-06T18:46:37Z

+                    },
+                    "id": "d814b48e-18f2-44ef-b8fa-3dba3244f24e",
+                    "label": {
+                        "en": "Owning Organization"


This is in drafts as well

seeker25 · 2026-08-06T18:47:33Z

-    def company_contributor_ids(self, username):
-        """The viewer plus the active members of every org the viewer actively
-        belongs to today, excluding any flagged inactive."""
-        if not username:
-            return set()
-        my_contributor_id = self.username_contributor_id(username)
-        if not my_contributor_id:
-            return set()
-
-        org_node = self.node_id(
-            GraphSlugs.CONTRIBUTOR, ContributorAliases.ASSOCIATED_ORGANIZATION
-        )
-        start_node = self.node_id(GraphSlugs.CONTRIBUTOR, ContributorAliases.START_DATE)
-        end_node = self.node_id(GraphSlugs.CONTRIBUTOR, ContributorAliases.END_DATE)
-        membership_ng = self._node_info(
-            GraphSlugs.CONTRIBUTOR, ContributorAliases.ASSOCIATED_ORGANIZATION
-        )[1]
-        today = timezone.now().date().isoformat()


moved to organization id or deleted

seeker25 · 2026-08-06T18:48:19Z

+    DRAFTS_CREATED_BY_ME = "DRAFTS_CREATED_BY_ME", "My drafts"
+    DRAFTS_BY_ASSOCIATED_ORGANIZATIONS = (
+        "DRAFTS_BY_ASSOCIATED_ORGANIZATIONS",
+        "Drafts of associated organizations",
+    )
+    FILINGS_CREATED_BY_ME = "FILINGS_CREATED_BY_ME", "My filings"
+    FILINGS_BY_ASSOCIATED_ORGANIZATIONS = (
+        "FILINGS_BY_ASSOCIATED_ORGANIZATIONS",
+        "Filings of associated organizations",
    )


new types toggled by external dash checkbox + filings + draft tab

seeker25 · 2026-08-06T18:49:34Z

@@ -1,30 +1,27 @@
 """Draft storage as resources of the standalone 'drafts' graph, one JSON blob


rewritten service

It looks like the user persisted in the edit_log is always admin, not the user that saves it. Are you seeing this locally too? Debugging the create/set_data functions, the user parameter is coming in as me (userid 5) but the value in the edit log is 1.

seeker25 · 2026-08-06T18:52:14Z

+            await Promise.all([
+                fetchDraftCards(),
+                fetchCompanyDraftCards(),
+                fetchMyProjects(),
+                fetchCompanyProjects(),
+            ]);


we grab these all at once, on the internal dashboard we just grab when we switch to the tab

I think that's ok

might get heavy depending on how big a company is.

seeker25 · 2026-08-06T18:53:24Z

I'm kind of thinking we might want to move the frontend unit tests files into a test directory

seeker25 · 2026-08-06T18:56:43Z

-    ApiPermitApplicationDestroyData,
-    ApiPermitApplicationDestroyResponse,
-    ApiPermitApplicationDestroyResponses,


Delete removal

seeker25 · 2026-08-06T18:57:01Z

-    ApiPermitApplicationUpdateData,
-    ApiPermitApplicationUpdateResponse,
-    ApiPermitApplicationUpdateResponses,


PUT removal, we might need this back in when we edit

seeker25 · 2026-08-06T19:00:03Z

+    verbs by http_method_names.
    """

+    http_method_names = ["get", "head", "options"]


follows generate.json now

seeker25 · 2026-08-06T19:01:02Z

    "permit_application": [
        "GET",
-        "PUT",
        "PATCH",


possibly put PUT back in when editing, I don't think we'll need delete for now?

seeker25 · 2026-08-06T19:02:20Z

Covered by other unit tests, also there are 400+ unit tests for cross model advanced search alone.

We can add the TestCase class and they will be picked up by the Django unit test runner and take only 0.7s to execute on my machine - should we add those? it will almost double the unit test count

seeker25 · 2026-08-06T19:03:16Z

    "arches-querysets @ git+https://github.com/bcgov/arches-querysets@performance_fix_geojson",
    "arches-workflow-stepper @ git+https://github.com/bferguso/arches-workflow-stepper@main",
-    "arches-zod-validation @ git+https://github.com/bcgov/arches-zod-validation@expose_resource_alias_function",
+    "arches-zod-validation @ git+https://github.com/bcgov/arches-zod-validation@generate_http_method_names",


seeker25 · 2026-08-06T19:04:02Z

+const urls: Record<string, unknown> = {
+    api_process_requirements: (id: string) =>
+        `/bcap/api/process_requirement/${id}`,
+    api_resource: (graphSlug: string, id: string) =>
+        `/bcap/api/resource/${graphSlug}/${id}`,
+    api_resource_blank: (graphSlug: string) =>
+        `/bcap/api/resource/${graphSlug}/blank`,
+    api_site_related_resources: (graphSlug: string, id: string) =>
+        `/bcap/api/arch_site_related_resources/${graphSlug}/${id}`,
+    api_workflow_draft: (graphSlug: string) =>
+        `/bcap/api/workflow_draft/${graphSlug}`,
+    api_workflow_draft_all: '/bcap/api/workflow_draft',
+    assignable_contributors: '/bcap/api/contributors/assignable',
+    assignable_groups: '/bcap/api/assignable_groups',
+    bcap_message_detail: (messageId: string) =>
+        `/bcap/api/bcap_message/${messageId}`,
+    bcap_message_resource_threads: (resourceId: string) =>
+        `/bcap/api/bcap_message/resource/${resourceId}/threads`,
+    bcap_message_thread_messages: (threadId: string) =>
+        `/bcap/api/bcap_message/thread/${threadId}`,
+    dashboard: '/bcap/api/dashboard',
+    dashboard_external: '/bcap/api/dashboard/external',
+    module_requirement: (
+        permitId: string,
+        moduleTileId: string,
+        requirementId: string,
+    ) =>
+        `/bcap/api/permit_application/${permitId}/module/${moduleTileId}/requirement/${requirementId}`,
+    permit_application_create: '/bcap/api/permit_application',
+    plugin: (slug: string) => `/plugins/${slug}`,
+    registration_link: '/bcap/api/registration_link',
+    seed_process_requirements: (permitId: string, permitType: string) =>
+        `/bcap/api/permit_application/${permitId}/process_requirement/${permitType}`,
+    unlinked_contributors: '/bcap/api/unlinked_contributors',
+};


all these in here all at once saves alot of repetition

P-Hansen

another monster PR, lgtm

seeker25 · 2026-08-07T14:15:53Z

I'm wondering if more of the routes should have been removed by codegen, but that's something we can fix in the next PR

* Interim commit * Interim commit * Add unit tests, delete all cnw rows * Align controlled list uris with https://localhost/bcap prefix Add migration to give Submitter group access to external dashboard * Fix Publication.json formatting * Fix skos file * Fix black format * Fix resource instance node search strings

* Add unit test for graph searchString validity. Fix Publication and Document Submission resouce models * Fix resource model format * lint * fix bcap message --------- Co-authored-by: Travis Semple <travis8814@gmail.com>

seeker25 added 30 commits July 29, 2026 13:50

expose drafts to staff, put in save and exit button for draft, allow …

45769f8

…staff to view drafts for editing

Add in workflow for permit app that points to itself as a workflow

b39bd5d

Permit app workflow added in

f1cff45

Submission/Messages button correct level - Process Requirement level Breadcrumbs /bands for Edit / Complete Checklist Split CompletedModules into folder View Arches - Icon for arches core Search looking icon - View Arches icon = Internal Dashboard

Filter by tiles with Messages internal dashboard

3d53014

Use dropdown list for actions - Edit Checklist put it in dots on Filing Summary Wire in unread counts for Drafts on backend Wire in external dashboard draft call, wasn't wired Drafts filter for External dashboard

small fix for sorting bar and requirementrow

d230f66

put in section or step resume for draft

6d20967

optimize

0b6f13d

permit package reload command

15b296b

rewrite bcap message service proper, split out question dialog

db4271f

implement assignee, get grid system working for dashboard, make band …

f099662

…a bit more fluid without having to reload

back to filing summary button for checklist, just in case

4667171

fix draft issues not showing investigation, also not refering to the …

2b52b20

…parent

Clean up sorting bar, fix blank assignee for staff

152d663

clean up

a20e057

make vertical spacing consistent for both screens

9a4483f

optimization for internal

6a5d43d

more tweaks

d820a4d

lint

590f515

expanded draft functionality

d4cd27c

more clean up

4f769af

lint

258c17c

code clean up

c408494

lint

67c7559

Wire in submission Company Projects, wasn't wired for some reason - m…

62dc110

…ore unit tests

front end unit tests

642adef

slim down unit tests

ea0f476

more unit tests for coverage

4cd41dd

unit test coverage

ace4825

clean out redundant comments

8d1f205

fix performance for unit tests

2fddc40

seeker25 commented Aug 6, 2026

View reviewed changes

P-Hansen approved these changes Aug 6, 2026

View reviewed changes

seeker25 requested a review from bferguso August 10, 2026 18:07

seeker25 and others added 12 commits August 10, 2026 14:37

Fix assignee contributor lookup for BCAP messaging

de819df

Add in changes to facilitate audit log behaviour

7463494

update to isAuthenticated for some routes

dc6c2a8

add in CI check for API codegen

5374b11

remove codegen check

8024314

fix message counts

7ee44c7

lint

6ae2eb0

Fix messaging for two users, still issues with multiple users

ef29d34

clean up

0d3dcc7

move over to vmodel instead of update

e234ef7

Add unit test for graph searchString validity (#1672)

9ac5f87

* Add unit test for graph searchString validity. Fix Publication and Document Submission resouce models * Fix resource model format * lint * fix bcap message --------- Co-authored-by: Travis Semple <travis8814@gmail.com>

seeker25 merged commit f585ec9 into release/2.0.x Aug 11, 2026
9 checks passed

seeker25 deleted the ts/feat/1656_company_project_visbility branch August 11, 2026 21:08

		@@ -1,30 +1,27 @@
		"""Draft storage as resources of the standalone 'drafts' graph, one JSON blob

Uh oh!

Conversation

seeker25 commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seeker25 commented Aug 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

P-Hansen left a comment

Choose a reason for hiding this comment

Uh oh!

seeker25 commented Aug 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

seeker25 commented Aug 5, 2026 •

edited

Loading