File Uploader - #1670
Open
P-Hansen wants to merge 21 commits into
Open
Conversation
seeker25
reviewed
Aug 11, 2026
…nternal.vue old code
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
reviewed
Aug 11, 2026
seeker25
approved these changes
Aug 11, 2026
Collaborator
There was a problem hiding this comment.
LGTM, I'd gun alot of your unit test comments though they are just noise and extra upkeep if refactoring
I noticed this with some of my comments in my code as well - they were stale and then the code was changed (and comment not always updated) -> which causes confusion :(
P-Hansen
marked this pull request as ready for review
August 19, 2026 00:13
bferguso
approved these changes
Aug 19, 2026
bferguso
left a comment
bferguso
left a comment
Collaborator
There was a problem hiding this comment.
Overall looks good. I think we can tune the multi file uploader a bit, but can do that as a separate PR if you want. Let's try to keep it as close to the GenericWidget pattern as possible, only deviating where absolutely necessary.
| :validateOnBlur="true" | ||
| > | ||
| <FieldSet legend="Document Submissions"> | ||
| <MultiFileUploader |
Collaborator
There was a problem hiding this comment.
Are we able to use the same pattern as the GenericWidgets here? Feels like a lot of props. It'd be nice if we could use the GenericWidget and just override the card-x-node-x-widget-data value to point at the MultiFileUploader component.
bferguso
requested changes
Aug 19, 2026
bferguso
left a comment
bferguso
left a comment
Collaborator
There was a problem hiding this comment.
Actually - let's make sure the unit test coverage is back up before we merge this in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1326
workflow for file upload
requires PR: 171 from arches common.