Skip to content

Brf/feat/add management for refresh permitting - #1671

Merged
seeker25 merged 9 commits into
ts/feat/1656_company_project_visbilityfrom
brf/feat/add_management_for_refresh_permitting
Aug 11, 2026
Merged

Brf/feat/add management for refresh permitting#1671
seeker25 merged 9 commits into
ts/feat/1656_company_project_visbilityfrom
brf/feat/add_management_for_refresh_permitting

Conversation

@bferguso

@bferguso bferguso commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator
  • Align controlled list node filters with controlled list URIs & standardize list URI prefix with https://localhost/bcap
  • Adds migration to give Submitter group access to Submissions plugin (dashboard)
  • Adds management command to refresh the Permitting resource models and SKOS LOVs

<dcterms:identifier>http://localhost:82/plugins/controlled-list-manager/item/496a6ae0-11f4-4ed8-bf32-f8008bbfa5c8</dcterms:identifier>
<dcterms:identifier>https://localhost/bcap/plugins/controlled-list-manager/item/496a6ae0-11f4-4ed8-bf32-f8008bbfa5c8</dcterms:identifier>
<skos:inScheme>
<skos:ConceptScheme rdf:about="http://localhost:82/e5691a39-41d1-417d-ae33-b0ca630f02ae">

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this still work on http://localhost:82? even though it's changed to https?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup - it just uses it as an ID, not an actual URL...

Comment on lines +17 to +22
GroupObjectPermission(
permission=view_plugin,
group=submitter,
content_type_id=get_content_type(submissions).pk,
object_pk=str(submissions.pk),
).save()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +92 to +101
if options["delete_tiles"]:
self.delete_permit_data()
if not options["skip_graphs"]:
self.reload_graphs()
if not options["skip_lists"]:
self.reload_lists()
if not options["skip_requirements"]:
self.reload_requirement_templates()
if not options["skip_reindex"]:
self.reindex_resources()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@seeker25 seeker25 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

highlevel looks good to me

}
},
"searchString": "/bcap/search?advanced-search=[{\"op\"%3A\"and\"%2C\"c4eca2de-9dea-11ed-9a7b-5254004d77d3\"%3A{\"op\"%3A\"eq\"%2C\"val\"%3A[{\"labels\"%3A[{\"id\"%3A\"891278e4-5d67-571a-a0c4-414896d36d1c\"%2C\"language_id\"%3A\"en\"%2C\"list_item_id\"%3A\"fd2053d3-c010-519a-97e5-52f3c7b508e2\"%2C\"value\"%3A\"Organization\"%2C\"valuetype_id\"%3A\"prefLabel\"}]%2C\"uri\"%3A\"%2Fbcap%2Fplugins%2Fcontrolled-list-manager%2Fitem%2Ffd2053d3-c010-519a-97e5-52f3c7b508e2\"}]}%2C\"e2f1c29a-c500-11ed-9089-5254004d77d3\"%3A{\"op\"%3A\"eq\"%2C\"val\"%3A\"\"}%2C\"c4ec9b2c-9dea-11ed-9a7b-5254004d77d3\"%3A{\"op\"%3A\"~\"%2C\"lang\"%3A\"en\"%2C\"val\"%3A\"\"}%2C\"c4eca13a-9dea-11ed-9a7b-5254004d77d3\"%3A{\"op\"%3A\"~\"%2C\"lang\"%3A\"en\"%2C\"val\"%3A\"\"}%2C\"a5b2cd72-c4f4-11ed-a06d-5254004d77d3\"%3A{\"op\"%3A\"~\"%2C\"lang\"%3A\"en\"%2C\"val\"%3A\"\"}%2C\"b5ed0072-c4f4-11ed-94de-5254004d77d3\"%3A{\"op\"%3A\"~\"%2C\"lang\"%3A\"en\"%2C\"val\"%3A\"\"}%2C\"99643f1e-9e4e-11ed-b6d5-5254004d77d3\"%3A{\"val\"%3A\"f\"}}]"
"searchString": "/bcap/search?advanced-search=[{\"op\"%3A\"and\"%2C\"c4eca2de-9dea-11ed-9a7b-5254004d77d3\"%3A{\"op\"%3A\"eq\"%2C\"val\"%3A[{\"labels\"%3A[{\"id\"%3A\"891278e4-5d67-571a-a0c4-414896d36d1c\"%2C\"language_id\"%3A\"en\"%2C\"list_item_id\"%3A\"fd2053d3-c010-519a-97e5-52f3c7b508e2\"%2C\"value\"%3A\"Organization\"%2C\"valuetype_id\"%3A\"prefLabel\"}]%2C\"uri\"%3A\"https://localhost/bcap/plugins/controlled-list-manager/item/fd2053d3-c010-519a-97e5-52f3c7b508e2\"}]}%2C\"e2f1c29a-c500-11ed-9089-5254004d77d3\"%3A{\"op\"%3A\"eq\"%2C\"val\"%3A\"\"}%2C\"c4ec9b2c-9dea-11ed-9a7b-5254004d77d3\"%3A{\"op\"%3A\"~\"%2C\"lang\"%3A\"en\"%2C\"val\"%3A\"\"}%2C\"c4eca13a-9dea-11ed-9a7b-5254004d77d3\"%3A{\"op\"%3A\"~\"%2C\"lang\"%3A\"en\"%2C\"val\"%3A\"\"}%2C\"a5b2cd72-c4f4-11ed-a06d-5254004d77d3\"%3A{\"op\"%3A\"~\"%2C\"lang\"%3A\"en\"%2C\"val\"%3A\"\"}%2C\"b5ed0072-c4f4-11ed-94de-5254004d77d3\"%3A{\"op\"%3A\"~\"%2C\"lang\"%3A\"en\"%2C\"val\"%3A\"\"}%2C\"99643f1e-9e4e-11ed-b6d5-5254004d77d3\"%3A{\"val\"%3A\"f\"}}]"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may add a unit test to flag drift in the search string and default controlled list values as this seems to keep biting us. Not sure if it's caused by the graph designer changing node IDs, or if there is something else going on...

@seeker25
seeker25 merged commit 481e358 into ts/feat/1656_company_project_visbility Aug 11, 2026
5 checks passed
@seeker25
seeker25 deleted the brf/feat/add_management_for_refresh_permitting branch August 11, 2026 16:13
seeker25 added a commit that referenced this pull request Aug 11, 2026
* expose drafts to staff, put in save and exit button for draft, allow staff to view drafts for editing

* Add in workflow for permit app that points to itself as a workflow

* Permit app workflow added in
Submission/Messages button correct level - Process Requirement level
Breadcrumbs /bands for Edit / Complete Checklist
Split CompletedModules into folder
View Arches - Icon for arches core Search looking icon - View Arches icon = Internal Dashboard

* Filter by tiles with Messages internal dashboard
Use dropdown list for actions - Edit Checklist put it in dots on Filing Summary
Wire in unread counts for Drafts on backend
Wire in external dashboard draft call, wasn't wired
Drafts filter for External dashboard

* small fix for sorting bar and requirementrow

* put in section or step resume for draft

* optimize

* permit package reload command

* rewrite bcap message service proper, split out question dialog

* implement assignee, get grid system working for dashboard, make band a bit more fluid without having to reload

* back to filing summary button for checklist, just in case

* fix draft issues not showing investigation, also not refering to the parent

* Clean up sorting bar, fix blank assignee for staff

* clean up

* make vertical spacing consistent for both screens

* optimization for internal

* more tweaks

* lint

* expanded draft functionality

* more clean up

* lint

* code clean up

* lint

* Wire in submission Company Projects, wasn't wired for some reason  - more unit tests

* front end unit tests

* slim down unit tests

* more unit tests for coverage

* unit test coverage

* clean out redundant comments

* fix performance for unit tests

* unit test optimization

* unit test fixes + optimizations

* update drafts so it uses same gen spec as creating the modules themselves, drafts use one large call to grab all drafts regardless of slug, update spec, use Typescript types, some typescript kung fu

* remove reload_permit_package + own_data_filter

* clean up + regenerate types + parentId query param for drafts + performance fixes for internal + unit test

* prevent drift by using the same structure from our codegen

* small change in order

* revert arches-queryset cache

* lint

* lib update for docker

* Add in a way to automatically goto the process requirement when clicking from the internal dashboard

* use data classes instead of dicts for the serializers, this will make typechecking detect code drift

* re organize workflow drafts as per Brett's suggestion also add in owning organization that we can expand to a list in the future

* refactor contributor service, split it into organization and contributor service

* contributor service moves cont

* Move draft_payload into it's own node so we can avoid writing audit log for it

* add view in arches at the module level

* small service moves

* refactor common code

* resource id use const

* codegen

* refactor to use WorkflowDraft for dashboard

* add in owning organization changes for permit app/drafts

* narrow down our views

* toml

* Add in filtering for company now, split the external dashboard into filings and drafts

* unit tests cover draft by associated organizations

* unit test addition + unit test clean up

* clean up is internal for drafts

* refactor common code

* refactor parts of unit tests clean up

* code issue fix

* unit test optimizations

* code cleanup

* lint

* cleanup

* cleanup duplication

* this unit test is already covered by unit/test_group_filter.py

* fix same org different creating user case

* tweaks for visibility

* move over api call to proper file

* clean up unit tests

* fix arches override, fix warning for search

* Fix assignee contributor lookup for BCAP messaging

* Add in changes to facilitate audit log behaviour

* update to isAuthenticated for some routes

* add in CI check for API codegen

* remove codegen check

* Brf/feat/add management for refresh permitting (#1671)

* Interim commit

* Interim commit

* Add unit tests, delete all cnw rows

* Align controlled list uris with https://localhost/bcap prefix
Add migration to give Submitter group access to external dashboard

* Fix Publication.json formatting

* Fix skos file

* Fix black format

* Fix resource instance node search strings

* fix message counts

* lint

* Fix messaging for two users, still issues with multiple users

* clean up

* move over to vmodel instead of update

* Add unit test for graph searchString validity (#1672)

* Add unit test for graph searchString validity. Fix Publication and Document Submission resouce models

* Fix resource model format

* lint

* fix bcap message

---------

Co-authored-by: Travis Semple <travis8814@gmail.com>

---------

Co-authored-by: Brett Ferguson <brett@qedsystems.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants