Add unit test for graph searchString validity - #1672
Merged
bferguso merged 4 commits intoAug 11, 2026
Merged
Conversation
bferguso
commented
Aug 11, 2026
bferguso
commented
Collaborator
- Add unit test to verify drift
- Fix Publication and Document Submission resource models
…cument Submission resouce models
Collaborator
Author
|
Still need to see why BCAP Message is failing the test. Will look after lunch. |
bferguso
marked this pull request as draft
August 11, 2026 18:57
Collaborator
|
sorry pushed 2 commits up |
seeker25
approved these changes
Aug 11, 2026
bferguso
marked this pull request as ready for review
August 11, 2026 20:53
bferguso
merged commit Aug 11, 2026
9ac5f87
into
ts/feat/1656_company_project_visbility
5 checks passed
seeker25
added a commit
that referenced
this pull request
Aug 11, 2026
* expose drafts to staff, put in save and exit button for draft, allow staff to view drafts for editing * Add in workflow for permit app that points to itself as a workflow * Permit app workflow added in Submission/Messages button correct level - Process Requirement level Breadcrumbs /bands for Edit / Complete Checklist Split CompletedModules into folder View Arches - Icon for arches core Search looking icon - View Arches icon = Internal Dashboard * Filter by tiles with Messages internal dashboard Use dropdown list for actions - Edit Checklist put it in dots on Filing Summary Wire in unread counts for Drafts on backend Wire in external dashboard draft call, wasn't wired Drafts filter for External dashboard * small fix for sorting bar and requirementrow * put in section or step resume for draft * optimize * permit package reload command * rewrite bcap message service proper, split out question dialog * implement assignee, get grid system working for dashboard, make band a bit more fluid without having to reload * back to filing summary button for checklist, just in case * fix draft issues not showing investigation, also not refering to the parent * Clean up sorting bar, fix blank assignee for staff * clean up * make vertical spacing consistent for both screens * optimization for internal * more tweaks * lint * expanded draft functionality * more clean up * lint * code clean up * lint * Wire in submission Company Projects, wasn't wired for some reason - more unit tests * front end unit tests * slim down unit tests * more unit tests for coverage * unit test coverage * clean out redundant comments * fix performance for unit tests * unit test optimization * unit test fixes + optimizations * update drafts so it uses same gen spec as creating the modules themselves, drafts use one large call to grab all drafts regardless of slug, update spec, use Typescript types, some typescript kung fu * remove reload_permit_package + own_data_filter * clean up + regenerate types + parentId query param for drafts + performance fixes for internal + unit test * prevent drift by using the same structure from our codegen * small change in order * revert arches-queryset cache * lint * lib update for docker * Add in a way to automatically goto the process requirement when clicking from the internal dashboard * use data classes instead of dicts for the serializers, this will make typechecking detect code drift * re organize workflow drafts as per Brett's suggestion also add in owning organization that we can expand to a list in the future * refactor contributor service, split it into organization and contributor service * contributor service moves cont * Move draft_payload into it's own node so we can avoid writing audit log for it * add view in arches at the module level * small service moves * refactor common code * resource id use const * codegen * refactor to use WorkflowDraft for dashboard * add in owning organization changes for permit app/drafts * narrow down our views * toml * Add in filtering for company now, split the external dashboard into filings and drafts * unit tests cover draft by associated organizations * unit test addition + unit test clean up * clean up is internal for drafts * refactor common code * refactor parts of unit tests clean up * code issue fix * unit test optimizations * code cleanup * lint * cleanup * cleanup duplication * this unit test is already covered by unit/test_group_filter.py * fix same org different creating user case * tweaks for visibility * move over api call to proper file * clean up unit tests * fix arches override, fix warning for search * Fix assignee contributor lookup for BCAP messaging * Add in changes to facilitate audit log behaviour * update to isAuthenticated for some routes * add in CI check for API codegen * remove codegen check * Brf/feat/add management for refresh permitting (#1671) * Interim commit * Interim commit * Add unit tests, delete all cnw rows * Align controlled list uris with https://localhost/bcap prefix Add migration to give Submitter group access to external dashboard * Fix Publication.json formatting * Fix skos file * Fix black format * Fix resource instance node search strings * fix message counts * lint * Fix messaging for two users, still issues with multiple users * clean up * move over to vmodel instead of update * Add unit test for graph searchString validity (#1672) * Add unit test for graph searchString validity. Fix Publication and Document Submission resouce models * Fix resource model format * lint * fix bcap message --------- Co-authored-by: Travis Semple <travis8814@gmail.com> --------- Co-authored-by: Brett Ferguson <brett@qedsystems.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.