Fix initial step validation not working + Add in Organization to Internal/External Cards and filing summary - #1687
Merged
Merged
Conversation
seeker25
commented
Aug 20, 2026
…ide mock that depends on import order
seeker25
marked this pull request as ready for review
August 20, 2026 18:14
seeker25
requested review from
P-Hansen and
bferguso
and removed request for
bferguso
August 20, 2026 18:38
P-Hansen
approved these changes
Aug 20, 2026
P-Hansen
left a comment
P-Hansen
left a comment
Collaborator
There was a problem hiding this comment.
LGTM hopefully we don't have to go past 6 inputs on the card, it's getting pretty full.
bferguso
reviewed
Aug 21, 2026
bferguso
left a comment
bferguso
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. I've got a descriptors function that I'll submit a PR to this branch so we can remove the code that fixes the trailing comma.
Collaborator
Author
|
perfect, failing now, updating to bcgov/bcgov-arches-common#173 |
use github:bcgov/bcgov-arches-common#ts/bugfix/general_fixes
seeker25
marked this pull request as draft
August 21, 2026 16:28
seeker25
marked this pull request as ready for review
August 21, 2026 16:36
Collaborator
Just submitted the descriptors PR to your branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dash has a clear indication on who owns the files on the dashboard (me or someone else)
#1356
#1685
bcgov/bcgov-arches-common#173