fix: #631 Validate planned development date - #1059
Merged
Merged
Conversation
ianliuwk1019
requested review from
DerekRoberts,
OlgaLiber2 and
arcshiftsolutions
as code owners
August 13, 2026 18:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforces validation of the
DEV_DATE(legacyDEVELOPMENT_DATE) property on FOM spatial file submissions, for cut blocks and road sections. Retention areas (WTRA) are unaffected — they carry no development date.Previously the field was only loosely checked and had issue - #629.
Changes
Format and calendar correctness (API)
DEV_DATEusesYYYY-MM-DDformat and a real calendar date; strict parsing replaces the previous lenient parse.NAME, or by its one-based position in the file when unnamed, so the row can be found in a large submission.Business range rule (API)
Relaxed lower bound for FINAL submissions (API)
Error dialog readability (Admin)
Behaviour change to be aware of
Validation runs only when a spatial file is submitted. Workflow state changes, the daily state-transition batch, and the cache refresh job do not touch spatial data, so an existing FOM cannot retroactively fail because a date has since moved into the past.
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: